GithubHelp home page GithubHelp logo

Comments (4)

saintf avatar saintf commented on June 16, 2024

Rather than doing that (Which is basically taking a ton of the heart away) would it be better if instead we allowed you to capture the request object provided by Feign?

You could hence perhaps take the request as a parameter and then use its internals to capture requestUrl/headers/etc - thoughts?

from feign-annotation-error-decoder.

StefanFellinger avatar StefanFellinger commented on June 16, 2024

It's an idea. Would be fine for us. Mabe you can provide a single DTO Object that holds request, response and the body or the method that resolves it. Then Exception Constructors need less parameters and the DTO can be extended when things change...

from feign-annotation-error-decoder.

saintf avatar saintf commented on June 16, 2024

Take a look at #18 - the idea is that it would then return a standard Feign Request object (look at https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/Request.java) which you can then use to get resolved URI/Headers/etc if you want.

If that looks good, let's close this ticket out and upvote that one. Are you ok to give it a try at making the changes and I can review afterwards?

from feign-annotation-error-decoder.

MariusKl avatar MariusKl commented on June 16, 2024

Thank you for adding this in #18

from feign-annotation-error-decoder.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.