Comments (4)
Rather than doing that (Which is basically taking a ton of the heart away) would it be better if instead we allowed you to capture the request object provided by Feign?
You could hence perhaps take the request as a parameter and then use its internals to capture requestUrl/headers/etc - thoughts?
from feign-annotation-error-decoder.
It's an idea. Would be fine for us. Mabe you can provide a single DTO Object that holds request, response and the body or the method that resolves it. Then Exception Constructors need less parameters and the DTO can be extended when things change...
from feign-annotation-error-decoder.
Take a look at #18 - the idea is that it would then return a standard Feign Request object (look at https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/Request.java) which you can then use to get resolved URI/Headers/etc if you want.
If that looks good, let's close this ticket out and upvote that one. Are you ok to give it a try at making the changes and I can review afterwards?
from feign-annotation-error-decoder.
Thank you for adding this in #18
from feign-annotation-error-decoder.
Related Issues (18)
- initial commit of annotation error decoder HOT 1
- Dont work use global interface HOT 5
- v1.0.3 does not work with feign-core 10.x.x HOT 10
- with move to feign-core 10.x.x, support capturing the request in Exception constructors HOT 6
- Add option to pass methodKey to exception constructor HOT 2
- AnnotationErrorDecoder throws IllegalStateException on validateGeneratorCanBeUsedToGenerateExceptions with null body and complex body decoder
- [Question] [support needed] Error Response Body is empty HOT 1
- [Question] - Annotation based Retry After Exception HOT 5
- ErrorHandlerMap empty if only define annotation class
- [Question] Ignore custom exception constructors at startup
- Gradle dependency HOT 4
- Meta-annotation support HOT 1
- Upgrade to Feign 10.10.x HOT 12
- Upgrade 11.0 HOT 3
- Where can I find an example to use with Spring and @FeignClient
- documentation should be explicit about the custom exception constructor contract HOT 3
- Use with Spring Cloud HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feign-annotation-error-decoder.