GithubHelp home page GithubHelp logo

Comments (2)

00chorch avatar 00chorch commented on June 3, 2024 1

Hi @adriantam, I'm working on this one. I will send a PR today/tomorrow.

from openfga.

00chorch avatar 00chorch commented on June 3, 2024

Hi @adriantam ,
as the merge was messy to compare/fix, I've reset local branch to match upstream/main and will re-submit the changes for review. This caused the PR #1605 to get closed. Can you please re-open it for me.

My plan is to:

  1. reopen in draft mode and review 2 out of the 4 func refactors in run.go file
  2. if ok, proceed to the last two refactors
  3. move from draft to formal PR review

The stepped approach is
a) reduce lines to review per iteration
b) avoid (or minimize) dealing with conflicts during merges with upstream

Thanks for your support

from openfga.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.