window.fullscreen toggling error on MacOS about lime

[player-03]

Try adding event listeners to each of the following:

• window.onFullscreen
• window.onMaximize
• window.onMinimize
• window.onRestore

How many of them get dispatched, and at what point in the process?

[player-03]

Well, I think we found the culprit. When we receive a "maximize" window event, we set __fullscreen to false before dispatching onMaximize.

There aren't any other references to onMaximize, so I think it's safe to conclude that's where it's coming from. (Not even references that should exist, like in this list.)

When testing on Linux, I can confirm that there's no onMaximize event, and therefore window.fullscreen behaves as it should, toggling every time F is pressed. And there's also no onRestore event when exiting fullscreen. I don't know why you're getting these extra events on Mac, but they're definitely not what's supposed to happen.

[increpare]

Okay, let's try that (for the record, here's the code with the inserted event handlers - https://gist.github.com/increpare/928e5ee0919d7da56d11ba2ab2c022b7 )

Pressing F three times:

Source/Main.hx:66: keydown
Source/Main.hx:67: old fullscreen value is false
Source/Main.hx:48: onFullscreen
Source/Main.hx:77: new fullscreen value is true
Source/Main.hx:52: onMaximize
Source/Main.hx:66: keydown
Source/Main.hx:67: old fullscreen value is false
Source/Main.hx:48: onFullscreen
Source/Main.hx:77: new fullscreen value is true
Source/Main.hx:66: keydown
Source/Main.hx:67: old fullscreen value is true
Source/Main.hx:77: new fullscreen value is false
Source/Main.hx:62: onRestore

Pressing G twice

Source/Main.hx:66: keydown
Source/Main.hx:67: old fullscreen value is false
Source/Main.hx:48: onFullscreen
Source/Main.hx:77: new fullscreen value is true
Source/Main.hx:52: onMaximize
Source/Main.hx:66: keydown
Source/Main.hx:67: old fullscreen value is false
Source/Main.hx:77: new fullscreen value is false
Source/Main.hx:62: onRestore

[increpare]

Oho. Maybe it's related to hitting the maximize button on OSX having the same effect as going fullscreen? (At some point years ago macos changed the behaviour of the fullscreen button from a more Windows-style "expand window to fill screen" to actual full-screen).