Comments (5)
I'm not sure that's necessary. InChI already also includes a connectivity table encoded as one of its layers, I believe.
from cmiles.
@jchodera, as far as I understand, the connectivity in the standard InChI is tautomer-invariant valance bond connectivity so the hydrogens are not explicitly numbered there. The connectivity table will also include the hydrogens and single / double / triple / aromatic bond.
Also, the canonicalization algorithm for the numbering is different than canoncial ordering of OpenEye or RDkit that is used to generate the mapped SMARTS. The connectivity will then have to be mapped onto the map indices in the SMARTS.
from cmiles.
What's the utility of having the complete atomic connectivity table if we have this information already represented in other ways (such as the atom-tagged SMILES)?
from cmiles.
Yes, you can get the information from the atom-tagged SMILES so it's not essential.
A better way to phrase this question is should we add this utility to cmiles? And if we do add something like this to cmiles utility, should we also have mapping from and to chemical graphs and SMILES here?
Currently these utilities are in fragmenter. But it might make more sense to have them here.
from cmiles.
Addressed by #13
from cmiles.
Related Issues (20)
- Spurious missing stereo warnings
- Fix `has_stereo_defined` for rdkit HOT 1
- Detect overdefined stereo
- conda package HOT 1
- cmiles.utils.to_canonical_label failure HOT 2
- Could get_molecule_ids() support OEMol and RDMol input?
- Standardize molecule support through openforcefield.topology.Molecule?
- Generating a QCSchema JSON from an OEMol?
- WARNING: Proton(s) added/removed
- Generating CMILES ids for an OEMol?
- Hydrogens move and stereochemistry flip when reading qcschema molecule HOT 1
- Failing tests HOT 3
- Better parsing of molecule inputs
- Ideas for future refactor
- Discrepancies in re-generated reference data HOT 1
- How to update reference files for new versions of RDKit
- RDKit 2020.09.3 changes
- OpenEye toolkits 2020.2.0 changes
- Problem when loading TorsionDrive qcmol from QCA HOT 4
- Explicit valence issue with rdkit HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmiles.