Comments (9)
great detective work, thanks!
from projectgenerator.
this sounds reasonable. does the same thing happen when you run
npm run build:osx
on osx? I've been curious if there are differences between the platforms with regards to symlinks.
If this is an issue with electron binary downloads (which our project is based off of) can you post an issue upstream at electron:
https://github.com/atom/electron
for example, I saw this as part of their build process but didn't track exactly what it's doing:
https://github.com/atom/electron/blob/master/tools/mac/create-framework-subdir-symlinks.sh
if it's not a problem with electron, it might be an issue with electron packager?
https://github.com/maxogden/electron-packager
(for example, the osx 10.8 problem was an upstream issue with unzipping empty folders, it's useful to track down which module is causing the problem, sometimes we can work our way around it.)
from projectgenerator.
this looks like a product of being packaged on linux, here's the framework on an osx dist vs what's made via the nightlies.
from projectgenerator.
i'm just checking this and the problem is not in the linux server which is generating the package correctly with those folders as soft links but in the zip file. zip doesn't support soft links, file permissions... that's why the linux downloads use tar.gz. When compressing the generated folder with zip it converts those links into real folders.
should we switch to tar.gz? i guess in osx it shouldn't be a problem no?
from projectgenerator.
ah that makes sense. Tar.gz should be fine ! Also, it looks like there might be a flag for symlinks?
http://serverfault.com/questions/265675/how-can-i-zip-compress-a-symlink
from projectgenerator.
oh, ok i've added the symlinks flag and am regenerating the nightlies now, if that doesn't work i'll change it to tar.gz
from projectgenerator.
i think it's fixed now:
http://ci.openframeworks.cc/versions/nightly/
it's slightly bigger than 97Mb but that could be related to the newer version of nodejs, the fodlers are now symlinks
if you want to double check just in case i'm missing something?
from projectgenerator.
looks good! I'm going to look at the icons now but the package seems pretty good to me
from projectgenerator.
ok i'm going to close this then
from projectgenerator.
Related Issues (20)
- macos notarization tool HOT 1
- Creating a VS project from OSX leads to folders created with "\" in their name HOT 2
- Android 2024 HOT 21
- Better UUID lib
- PG - Addons libs/ MAC folder not used
- PG macOS Notorization - Need some extra info HOT 1
- ProjectGenerator add-on libs pathing issue and src subfolders not linked correctly HOT 42
- Clean on Xcode not working due to bin/data lacking attributes HOT 3
- Visual Studio max project name length? HOT 3
- VS missing addon lib sub folder source causing issues HOT 3
- macOS developer agreements need accepting
- ofTargetPlatform OF_TARGET_MACOS missing HOT 2
- zsh: killed if OF uses download_latest_libs.sh HOT 5
- about the new name scheme for PG-generated projects: ISO 8601 and uniqueness within a given day HOT 1
- first run in package location on osx yields can't find oF path what HOT 5
- projectGenerator - Broken things HOT 1
- Latest not working on macOS v.58 HOT 5
- PG v.61 - VS addons issue when projectGenerator not in oF dir HOT 2
- Current nightly PG broken ( on macOS at least )
- PG not detecting OF path correctly ( regression ) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from projectgenerator.