GithubHelp home page GithubHelp logo

Comments (9)

kylemcdonald avatar kylemcdonald commented on September 10, 2024 1

great detective work, thanks!

from projectgenerator.

ofZach avatar ofZach commented on September 10, 2024

this sounds reasonable. does the same thing happen when you run

npm run build:osx

on osx? I've been curious if there are differences between the platforms with regards to symlinks.

If this is an issue with electron binary downloads (which our project is based off of) can you post an issue upstream at electron:

https://github.com/atom/electron

for example, I saw this as part of their build process but didn't track exactly what it's doing:

https://github.com/atom/electron/blob/master/tools/mac/create-framework-subdir-symlinks.sh

if it's not a problem with electron, it might be an issue with electron packager?

https://github.com/maxogden/electron-packager

(for example, the osx 10.8 problem was an upstream issue with unzipping empty folders, it's useful to track down which module is causing the problem, sometimes we can work our way around it.)

from projectgenerator.

ofZach avatar ofZach commented on September 10, 2024

this looks like a product of being packaged on linux, here's the framework on an osx dist vs what's made via the nightlies.

screen shot 2015-10-18 at 5 44 59 pm

from projectgenerator.

arturoc avatar arturoc commented on September 10, 2024

i'm just checking this and the problem is not in the linux server which is generating the package correctly with those folders as soft links but in the zip file. zip doesn't support soft links, file permissions... that's why the linux downloads use tar.gz. When compressing the generated folder with zip it converts those links into real folders.

should we switch to tar.gz? i guess in osx it shouldn't be a problem no?

from projectgenerator.

ofZach avatar ofZach commented on September 10, 2024

ah that makes sense. Tar.gz should be fine ! Also, it looks like there might be a flag for symlinks?

http://serverfault.com/questions/265675/how-can-i-zip-compress-a-symlink

from projectgenerator.

arturoc avatar arturoc commented on September 10, 2024

oh, ok i've added the symlinks flag and am regenerating the nightlies now, if that doesn't work i'll change it to tar.gz

from projectgenerator.

arturoc avatar arturoc commented on September 10, 2024

i think it's fixed now:

http://ci.openframeworks.cc/versions/nightly/

it's slightly bigger than 97Mb but that could be related to the newer version of nodejs, the fodlers are now symlinks

if you want to double check just in case i'm missing something?

from projectgenerator.

ofZach avatar ofZach commented on September 10, 2024

looks good! I'm going to look at the icons now but the package seems pretty good to me

from projectgenerator.

arturoc avatar arturoc commented on September 10, 2024

ok i'm going to close this then

from projectgenerator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.