GithubHelp home page GithubHelp logo

Comments (2)

wilbrdt avatar wilbrdt commented on May 24, 2024

It is indeed a grey area of the LRS specification, and I understand that it can be a pain to work around it.
I think removing the duplicate statements from the batch and continue processing would be a logic thing to do.
I think it would require to implement a deep comparison of statements to cover the following cases:

  • If LRS receives a statement with an ID it already has a statement for, and statements don't match: don't do anything, return a 409 Conflict
  • if LRS receives a statement with an ID it already has a statement, and statements match: remove statement from batch and continue posting the batch.

This deep comparison would come with a performance cost (at least until pydantic v2 is out 🔜), but would be mitigated by only checking the duplicate ids.

However, I'm not so sure about adding the found duplicates into the response details, as we already return the array of statements that has been posted. What would you suggest?

from ralph.

bmtcril avatar bmtcril commented on May 24, 2024

I think the deep comparison would be good once it can be done, though even that is complicated in the spec since some fields should not be considered in the comparison. I forgot that the array of statements was returned, that is totally sufficient!

from ralph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.