overtrimming of reads about fastp

[jdidion]

To follow up on this: I tried trimming using the example data again but without specifying the adapter sequences and the reads were not trimmed. So to clarify the issue, it is with spurious match of the adapter to the read. I think you need to add the equivalent of the -O parameter in Atropos and Cutadapt. Also note that, with the alternate option I describe above (using random match probability), Atropos uses a heuristic (that was copied from SeqPurge) to require both adapter sequences to match their respective reads when the match length is <= than some threshold (9 bp by default), regardless of the probability. This seems to be necessary to achieve good performance with short adapter matches.

[sfchen]

Thank you John.

In current implementation, fastp will trim the reads if it matches the adapter with 4 or more bases in 3' end. This may introduce a bit overtrimming (may overtrim <0.1% of the data for 150bp reads), but will definitely give cleaner data.

It's a good idea to expose a parameter to change this setting. I will implement this in next release.

[komaljain3]

When can we expect this new feature to be released? The -O option in Cutadapt is really useful.