ui.iconset.classic: SAT build failure about openhab-webui

[maggu2810]

@martinvw Didn't you move to a pure Maven build?
All the POMs below features/p2 should not be realted as they are not used by the core bundles.

To answer your question: No, SAT is still not enabled in openHAB Core.

See also: openhab/static-code-analysis#341

[maggu2810]

I wonder, why I am running into that errors.
Does the build work on your systems or is it known to be broken ATM?

[kaikreuzer]

SAT checks are deactivated on the Jenkins build, that's why...

[maggu2810]

Then I don't need to wonder. Thanks for the information.

[wborn]

It no longer runs SAT at all now, probably because of the POM changes in #15 @martinvw?

[martinvw]

Yes if it came through the tycho parent that would explain, I did not deliberately solve this issue 😊

[martinvw]

@maggu2810 is the SAT still enable in openhab-core, the only usage of sat.version which I see is: https://github.com/openhab/openhab-core/blob/master/features/p2/poms/pom.xml.

Running the first part of the openhab-core build also does not show SAT output?

If its enable it openhab-core what would then be the correct / intended inheritance? or should we duplicate the sat now locally?

[martinvw]

@martinvw Didn't you move to a pure Maven build?
All the POMs below features/p2 should not be realted as they are not used by the core bundles.

Yes indeed, so it seems that I longer inherit any SAT configuration

To answer your question: No, SAT is still not enabled in openHAB Core.

So that now also applies to this project, I opened an issue for it: #32