Update to support Java Modules Plugin version 1.6.0 about javafx-gradle-plugin

[tobiasdiez]

Since the version 1.7 of the gradle modules plugin was just released, is there any chance 0.0.9 gets released soon as well?

[tlinkowski]

To update org.javamodularity.moduleplugin to 1.6.0, please replace org.javamodularity.moduleplugin.tasks.ModuleOptions with org.javamodularity.moduleplugin.extensions.RunModuleOptions here:

javafx-gradle-plugin/src/main/java/org/openjfx/gradle/tasks/ExecTask.java

Line 38 in 9727489

import org.javamodularity.moduleplugin.tasks.ModuleOptions;

and ModuleOptions with RunModuleOptions here:

javafx-gradle-plugin/src/main/java/org/openjfx/gradle/tasks/ExecTask.java

Line 76 in 9727489

ModuleOptions moduleOptions = execTask.getExtensions().findByType(ModuleOptions.class);

[msgilligan]

@johanvos Any chance this update can be made as part of (or shortly following) any updates for OpenJFX 13?

[jperedadnr]

@msgilligan, @tlinkowski, @yuliu2016, now that the PR #62 has been merged, a new snapshot of the plugin is available here.

It would be great if you could test it and provide some feedback before we release it?

You know how to do it, but just in case, add this to your settings.gradle file:

pluginManagement {
    repositories {
        maven {
            url "https://oss.sonatype.org/content/repositories/snapshots"
        }
        gradlePluginPortal()
    }
}

[yuliu2016]

I've tried this out with my projects. The JavaFX plugin itself was fine and working, but the Modules plugin has some refactoring/breaking changes in version 1.6.0. Specifically, I had an issue with java9-modularity/gradle-modules-plugin#118 (project doesn't work with the Kotlin plugin applied), but I worked around it by having another submodule (without the Kotlin plugin) depend on the Kotlin module.

[jperedadnr]

@yuliu2016 Thanks for testing. So nothing that can be fixed from the JavaFX gradle plugin, right?

[yuliu2016]

I don't think there's anything to be done

[msgilligan]

@jperedadnr I finally created a branch of my ConsensusJ/wallet-framework project that uses 0.0.9-SNAPSHOT and Modules Plugin 1.6.0. Note that I'm also using the Badass Jlink Plugin. Everything builds and runs correctly!

Here's a WIP PR with the changes: ConsensusJ/wallet-framework#7 -- you can see that both Github Actions and GitLab CI were able to build the branch.

When 0.0.9 final is released, I'll update this PR and merge it into master.

[msgilligan]

@tlinkowski Have you tested the snapshot? Any reason not to release it?

@jperedadnr Are you ready to release 0.0.9?

(I'm ready to upgrade my projects to 0.0.9 release and Modules plugin 1.6.0 😁)

[tlinkowski]

@tlinkowski Have you tested the snapshot? Any reason not to release it?

No, I haven't.

Sorry, but I have never even used javafx-gradle-plugin. I came here from java9-modularity/gradle-modules-plugin#80 (comment) to share an overview on how to update this plugin (as I know the internals of gradle-modules-plugin).

Unfortunately, gradle-modules-plugin has some major bugs (e.g. mentioned java9-modularity/gradle-modules-plugin#118), but I won't find the time to fix them in the foreseeable future.

[msgilligan]

Unfortunately, gradle-modules-plugin has some major bugs

Are those bugs present in 1.6.0 but not in 1.5.0?

[tlinkowski]

I'm not sure about the other bugs, but java9-modularity/gradle-modules-plugin#118 (mentioned before) is almost certainly a regression introduced in 1.6.0 by java9-modularity/gradle-modules-plugin#101.

[samypr100]

It seems 0.0.9 was released on 28 June 2020. I believe this can be closed.