0.4.1 breaks openstack/barbican about pykmip

[joel-coffman]

Yes, the Barbican tests were reaching into some of the PyKMIP internals -- see bug 1522856. There is a change request to remove those assertions in the stable/kilo branch: https://review.openstack.org/#/c/257523/. I'll see if I can push that change along...

I believe that the following 20dbad5 is a backwards incompatible change and should have bumped the major version

Yeah, we weren't expecting the Barbican unit tests to rely on PyKMIP's internal data structures, which are occasionally updated as new features are added.

[tbreeds]

Thanks. I'm getting a different back trace and that patch you refer to doesn't fix it for me (with 0.4.1) I get:

Traceback (most recent call last):
File "barbican/tests/plugin/test_kmip.py", line 423, in test_store_private_key_secret_return_value
return_value = self.secret_store.store_secret(secret_dto)
File "barbican/plugin/kmip_secret_store.py", line 350, in store_secret
self._raise_secret_general_exception(result)
File "barbican/plugin/kmip_secret_store.py", line 589, in _raise_secret_general_exception
raise ss.SecretGeneralException(msg)
barbican.plugin.interface.secret_store.SecretGeneralException: Problem seen during crypto processing - Reason: Status: ResultStatus.SUCCESS, Reason: None, Message: None

FAIL: barbican.tests.plugin.test_kmip.WhenTestingKMIPSecretStore.test_store_symmetric_secret_return_value

Which seems to be because result.result_status.enum is <enum 'ResultStatus'> and not ResultStatus.SUCCESS as expected.

Anyway this is largely moot. Changing internal APIs is fine, the best fix IMO for Barbican in kilo is to limit pykmip which is being discussed here: https://review.openstack.org/#/c/260599/

We just need to work out the correct cap.
My suggestion is capping in <0.4.0 that way we're open to any critical security fixes in 0.3.X and we neatly do not overlap with the liberty requirements.

[joel-coffman]

Looks like https://review.openstack.org/#/c/260599/ is the correct path so I'm closing this issue.