LooseApplication=true in 3.8.2 will deploy wrong artifacts about ci.maven

[cherylking]

@bmarwell I refreshed the 3.8.3-SNAPSHOT so it contains this fix.

[bmarwell]

I also tried to add <type>jar</type> to my dependencies, but OL still chose to use the .bundle artifacts.

Internally in Liberty, this leads to a ClassNotFoundException.

[cherylking]

I think this line of code is what is adding the .bundle to the entry.

[cherylking]

@bmarwell Is the correct extension always jar for a bundle packaging type? My quick search makes me think yes. But this is the first I've seen it used. I think the fix is easy and straight forward.

Not sure why it broke between versions though, as this code has been the same or similar for quite a while (the getAppFileName method used to be in DeployMojoSupport and has always used the packaging type for the extension).

[bmarwell]

Might have been broken because of my commits, no? 😉

Yes you're right. Bundle types are in the end just jar files with extra descriptors. If it wasn't my commit, I have no idea what broke it.

[bmarwell]

I still see this in the apps/shiro.xml file:

    <archive targetInArchive="/WEB-INF/lib/shiro-core-2.0.0-SNAPSHOT.bundle">

You can try yourself. Just check out apache/shiro (main branch) and run:

mvn -Prun-its verify -pl integration-tests/jaxrs/openliberty -am

To deploy without the .war archive and use loose applications instead to reproduce the problem, change <looseApplication>false</looseApplication> to true in integration-tests/jaxrs/openliberty/pom.xml.

But then, thinking about it, maybe my proxy is caching too agressively.

[cherylking]

@bmarwell I will double check and reopen if I see the same thing. The test case I modified to include a bundle is passing, but perhaps the changes I made were not enough for the more complex application that you have.

[bmarwell]

Where did you upload the 3.8.3-SNAPSHOT to again?

[cherylking]

Where did you upload the 3.8.3-SNAPSHOT to again?

sonatype

[cherylking]

@bmarwell I just ran that command successfully after cloning the apache/shiro main branch locally and modifying <looseApplication> to true. I see the following in the apps/shiro...xml file.

 <archive targetInArchive="/WEB-INF/lib/shiro-core-2.0.0-SNAPSHOT.jar">
        <dir sourceOnDisk="/Users/cherylking/gitForks/shiro/core/target/classes" targetInArchive="/"/>
        <file sourceOnDisk="/Users/cherylking/gitForks/shiro/core/target/tmp/META-INF/MANIFEST.MF" targetInArchive="/META-INF/MANIFEST.MF"/>
    </archive>

This ran with my locally built 3.8.3-SNAPSHOT build of LMP. I will wipe out my local .m2 and see if the snapshot in sonatype is not current for some reason.

Update: Even after wiping my local .m2 the build passed successfully using the snapshot available in sonatype. Did you add the following to your pom.xml to pick up the snapshot?

 <pluginRepositories>
        <!-- Configure Sonatype OSS Maven snapshots repository -->
        <pluginRepository>
            <id>sonatype-nexus-snapshots</id>
            <name>Sonatype Nexus Snapshots</name>
            <url>https://oss.sonatype.org/content/repositories/snapshots/</url>
            <snapshots>
                <enabled>true</enabled>
            </snapshots>
            <releases>
                <enabled>false</enabled>
            </releases>
        </pluginRepository>
    </pluginRepositories>

[bmarwell]

Yes I did, but somehow it didn't work for me. Will check later on why. Thanks for confirming this issue has been resolved! 🙏🏻