Comments (5)
Noting that we didn't carry forward the "property" config in the past in the case of 'serverEnvFile' replacing 'serverEnv'.
So you can only do -DserverEnvFile
not -DserverEnv
now.
Not saying we are completely bound by that decision. If we want to support both properties we have to flag as an error or define our own precedence between them since I'm not sure how to have Maven do that for us. I think an error would be OK.
from ci.maven.
It blocked the new guide https://github.com/OpenLiberty/draft-guide-testcontainers.
from ci.maven.
@gkwan-ibm Hi Gilbert, can you try containerRunOpts
instead to make progress?
We replaced dockerRunOpts
with containerRunOpts
, but intended to preserve being able to specify dockerRunOpts
. I think it works if you specify it in the pom.xml, but maybe not as a property from the command line. I can fix that in the next release so both work from the command line.
from ci.maven.
-DcontainerRunOpts
works, thanks
BTW, Rancher Desktop has the same issue.
from ci.maven.
@gkwan-ibm I'm glad containerRunOpts
works. By the way, our plugins have no awareness of whether you are using Colima or Rancher Desktop or whatever else. This is just a plugin configuration parameter that we modified to be more generic instead of Docker specific.
from ci.maven.
Related Issues (20)
- SVT: Application keeps on restarting in Dev mode without making any changes to the app HOT 9
- Maven properties are not being replaced by their values when prepare-feature reads a bill of materials
- Add support for Maven property references in `copyDependencies`
- Add automated test for Podman support
- In multi-module dev mode, the DevUtil compile fails for a sub-module although compile mojo compilation suceeds.
- Duplicate jvm.options entries generated from a single -Dliberty.jvm.xyz=123 system property in v3.10 HOT 3
- Confusing when user provides app config but plugin generates one anyway because of location mismatch HOT 2
- liberty-maven-plugin should rely on the build toolchain configuration to build / rebuild code HOT 3
- Maven plugin prints extraneous warnings HOT 2
- Unable to measure code coverage after migrating to 3.10 HOT 5
- Warning message on download of feature *.esa.ac file when installing features yet feature verification seems to succeed HOT 4
- Support expansion variables for server.env config files
- In liberty:create goal, liberty-plugin-config.xml doesn't reflect precedence of liberty.bootstrap.* props over <bootstrapPropertiesFile> plugin config HOT 2
- Deploy goal doesn't allow for user-specified <springBootApplication> config in server.xml; will always generate deployment config HOT 1
- Exception when 'run' goal is executed for SpringBoot repackaged WAR with looseApplication=false and SB deploy
- Detect installation directory changes when `dev` mode is running and handle it somehow
- Incorrect values in liberty-plugin-config.xml for assemblyArtifact and assemblyInstallDirectory HOT 1
- Handle spaces in project path for devc HOT 3
- Error found when running Liberty dev container mode with Liberty Maven Plugin 3.10.1 on Linux HOT 2
- Maven Version issue HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ci.maven.