Peer Review - Mac about guide-social-media-login

[MaiHameed]

• :page-tags: includes Social Media Login which isn't a tag, see here
• SEO description Liberty using the SocialLogin feature should be Social Media Login

What you'll learn

• Should include Amazon in the first paragraph.

Generating a self signed certificate

To generate certificates for your service to use for HTTPS connections, ...

• The command prompts the user for a password, might want to add that to the guide, similar to the next paragraph When prompted, set the password...
Before the certificate and private key can be imported into the keystore for your service, ...
• The guide asked us to generate a certificate, where did the key come from? Might need some clarification.

keytool \
    -importkeystore \
    -srckeystore certificate.p12 \
    -srcstoretype PKCS12 \
    -destkeystore key.p12 \
    -deststoretype PKCS12

• It prompts us for multiple passwords, clarify if it's asking to set a password or to use a password we set previously

Setting up for GitHub

keytool \
    -import -trustcacerts \
    -file github.pem \
    -alias github \
    -keystore slts.p12 \
    -storetype PKCS12 \
    -storepass changeit
keytool \
    -import -trustcacerts \
    -file github_api.pem \
    -alias github_api \
    -keystore slts.p12 \
    -storetype PKCS12 \
    -storepass changeit

• Terminal prompt Trust this certificate? [no]: add in the guide that it will prompt you, and to respond with y.

• Button says "Register a new application" not "New OAuth App"
• Maybe specify somewhere in the guide that you only need to set up once using EITHER GitHub, Amazon, or Google, depending on which social service you want to use for your app.

Configuring the security and social media login

• Probably should mention here that the user should only add the specific configuration corresponding to their social platform of choice (Amazon, GitHub, Google) to the server.xml file.

Configuring the security roles

• The HelloService hotspot isn't working

Adding [social-platform] login configuration

• Add an action block to specify that the user needs to replace the values of certain keys to keep it consistent throughout guides

Running the application

• The http link doesn't work in Chrome. Throws an Your connection is not private NET::ERR_CERT_INVALID error. I assume it needs to be a https link since the rest of the links are https
• Getting errors when trying to access the app.

[INFO] [ERROR   ] CWWKS5461E: The social login feature encountered an error while getting user information from the user API [https://api.github.com/user/emails] that is configured for social login configuration [githubLogin]. CWWKS5490E: Cannot process the response from the [https://api.github.com/user/emails] user API endpoint. The response status was [401], error was [{"message":"Requires authentication","documentation_url":"https://developer.github.com/v3/users/emails/#list-email-addresses-for-a-user"}] and the error description was [null].
[INFO] [ERROR   ] CWWKS5452E: The social login feature cannot authenticate the user because the response from the user API that is configured for the social login configuration [githubLogin] is null or empty.

[k-rtik]

The http link doesn't work in Chrome. Throws an Your connection is not private NET::ERR_CERT_INVALID error. I assume it needs to be a https link since the rest of the links are https

The error is because we are using a self-signed certificate. There should be an option to continue anyway (Advanced --> Continue Anyway).
The https links are the endpoints used by the socialLogin feature. HelloService uses http