GithubHelp home page GithubHelp logo

Comments (2)

antonio-osorio avatar antonio-osorio commented on June 18, 2024

@hinshun I would like to move import testing out of this ticket. The way that it is implemented right now it communicates with the buildkit client even for local files so the testing is a bit more involved.

from hlb.

hinshun avatar hinshun commented on June 18, 2024

@antonio-osorio You're right, we should of moved it over in the first place, sorry. I think the compile_test.go really should be just testing the output of checker.Check and not the full Compile. I moved compile_test.go to checker/checker_test.go and simplified the test. I added an import test there, could you please port your test cases over this: #96

from hlb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.