GithubHelp home page GithubHelp logo

Comments (3)

asadowns avatar asadowns commented on August 25, 2024 1

I would say moving the request parameters into a query string is probably the correct approach here.
I don't believe there is the need for complex geometric shapes if the base geometry for the particular MDS client is provided as part of the token based auth.
Using a POST to retrieve data is often considered to be not semantic.

I would recommend keeping /trips and /status_changes as GET and clarifying around query parameters. I provided a potential approach in #64.

On the agency side I think it may be a bit early to deciding if service_areas need support for specific provider_id or an additional /:id route. I think both of these are good ideas to keep in mind moving forward but I don't think there should necessarily be an update now without a use case.

Let me know what you think!

from mobility-data-specification.

migurski avatar migurski commented on August 25, 2024 1

GET parameters is the right spot for this. Would you be comfortable documenting these using RFC6570-compliant form-style query expansion?

Example: /service_areas{?provider_id}{?service_area_id}.

from mobility-data-specification.

thekaveman avatar thekaveman commented on August 25, 2024

I think part of the confusion is, these query parameters aren't spelled out anywhere in the spec yet. But I also don't see where it is stated that MDS is expecting GET request bodies? That sounds crazy, I totally agree it is a bad idea @oderby!

I also tend to agree with @asadowns and @migurski here, these are very clearly GET requests (read-only, should be idempotent given the same parameters, etc.). @asadowns did some initial work on defining the query params over on #64 - can we move this discussion to that proposal so we can comment on some actual changes to the language in the spec?

(BTW I also really like the suggestion of tying the geo-area to the auth token (see #60) from @asadowns, thus obviating the need for that data on every request.)

I'm closing this one to hopefully move the discussion over to these ongoing threads. Thanks!

from mobility-data-specification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.