GithubHelp home page GithubHelp logo

Comments (10)

 avatar commented on May 15, 2024

After inserting the fingerprint manually in the db (authentication does not work on my end) I had a first look at the ingame UI and I have to say that I really like how it looks. I'm not so sure if the "Registered user" badge really is a good idea as it feels a bit redundant to the new player indicators. Instead, there could be a list of default badges with references to the c&c saga for example of which the user could chose one from. In either case (and if there should be something like a default/set of standard badges) this is something the OpenRA devs will need to decide so this is just a suggestion, see #21.

from openrauseraccounts.

 avatar commented on May 15, 2024

I will implement an a set of default badges which will be shown as radio buttons in the UCP badges module and add a config option for enabling/disabling the feature in the ACP badges module. This will exist next to the badge ordering interface and will if activated and set to use a default badge reduce the number of shown badges from the ordering table by one, so it stays at 5 in total. Radio buttons will be added/removed for each badge that is marked as "default" in the ACP badge module.

from openrauseraccounts.

 avatar commented on May 15, 2024

I have implemented an interface which allows users to select a default badge from badges that are marked as "Set to default" in the ACP badges module. "Mod Fan Club" is the label which I defined in the ACP badges module when adding the badges.

See demo below:
13723

The feature is finished but not linked to a config option yet which is the last thing to do here. Once you have set a default badge, you can not remove it but only set another default badge. Removal could be implemented too but I don't plan to do so at the moment.

from openrauseraccounts.

pchote avatar pchote commented on May 15, 2024

This looks really nice, but seeing this makes me think that we really should support enabling multiple default badges (players might want to be in more than one fan club, or advertise more than one OS).

How about having a second table listing the default badges with a checkbox on whether to include in the profile. Enabling the checkboxes then adds them to the profile badges section.

from openrauseraccounts.

 avatar commented on May 15, 2024

What about if we use hidden checkboxes instead of radio buttons for the default icons? I like the look of it more than having another table tbh. This would also mean less work. You could then select multiple icons and they would be saved in the user badge table on submit. This would also allow to remove all default badges because unlike radio buttons in a group, checkboxes can be all unchecked.

from openrauseraccounts.

pchote avatar pchote commented on May 15, 2024

I like your idea above for having both the default mods and OS choices (possibly including different linux distros) as default options. This means at least 6, but possibly more than 10 default badge choices. It would IMO be messy to not have a table for this many entries.

from openrauseraccounts.

 avatar commented on May 15, 2024

Good point. Let me see if I can come up with a good visual implementation, otherwise I will take the approach you mentioned.

from openrauseraccounts.

 avatar commented on May 15, 2024

Implemented the UI for selecting/unselecting default badges. The grouping by OS/Mod/Misc will require another yes/no input in the ACP badges module which I haven't done yet.
100

from openrauseraccounts.

 avatar commented on May 15, 2024

There is now a ACP module mode to add/edit/delete badge types and a list of these types to select an option from when adding new badges.

Feature is finished with the mentioned limitation that you currently can't remove the last default badge once you have selected one, which is something we can live with in v1 IMO.

from openrauseraccounts.

 avatar commented on May 15, 2024

You can now remove all badges from your profile so this can be closed.

from openrauseraccounts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.