Polish MCV packing logic about ra2

[Mailaender]

💡 That is why the game doesn't have an undeploy cursor.

[penev92]

One accidentally cancelled Nuke silo, coming up!

[GraionDilach]

Actually, this has pros and cons. A consequence of this in OpenRA is that you can finally set rallypoints for mobile war factories - in RA2 trying to set those resulted with the actual factory undeploying.

[MustaphaTR]

I think it should be settable under Transforms: so we can use it for CYards but modders may disable it for MWFs.

It would work, I think, if you required a force-move (ALT) to do it. That would prevent accidental deploys and still allow rally points.

I think the big trouble here is the way that the conyard decides what moves are allowed. The conyard doesn't know about the movement types of the unit its becoming, and there's a lot of logic that it's not equipped to handle. We need a trait to do those calculations, but we can't easily just put one onto the conyard (what trait would that be, even? What if you have a flying MCV that uses Aircraft rather than Mobile?).

Once such a trait was written, we would then need to communicate the movement order to the newly-undeployed MCV. That would be the easier part, I think, but would still require changes to the transformation process.

[GraionDilach]

FWIW this issue should probably be moved to upstream because TS had this as well (in TS, rally points were ordered with Alt-click, which is why the two could be combined).

[Mailaender]

This was added in OpenRA/OpenRA#16607.