GithubHelp home page GithubHelp logo

Comments (4)

agentzh avatar agentzh commented on June 9, 2024

Well, ngx_http_lua already supports the init parameter of incr, and we can utilize it here in this library.

I don't want this library to depend on a new 3rd-party nginx C module. But you are free to do whatever new feature experiments yourself :)

from lua-resty-limit-traffic.

alonbg avatar alonbg commented on June 9, 2024

@agentzh, sure, I would prefer not to reinvent stuff :)
But everything (logic under limit_req.incoming() as I described), preferably, should take place within a ngx_shmtx_lock section.
For sliding window I do need the queue. Did you mean adding this functionality to shared_dict list api ?

from lua-resty-limit-traffic.

agentzh avatar agentzh commented on June 9, 2024

@alonbg the standard lua_shared_dict implementation in ngx_http_lua_module already supports lists (or queues). Check it out to see if it fits your needs.

from lua-resty-limit-traffic.

alonbg avatar alonbg commented on June 9, 2024

@agentzh, for my case, using lua_shared_dict lists might cause a race condition. Well, I can use the lua lock API but there would be an overhead if used for every request. Actually, better to think of it as a special kind of rolling incr, which is initialized with window, resolution and an optional max value (being the max sum of all queue elements ). The data structure behind is the queue and the timestamp. I think I'll go forward with the c-api separate modul option and if it's generic enough you could consider it later on for ngx_http_lua_model.
Thanks

from lua-resty-limit-traffic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.