Comments (4)
Well, ngx_http_lua already supports the init
parameter of incr
, and we can utilize it here in this library.
I don't want this library to depend on a new 3rd-party nginx C module. But you are free to do whatever new feature experiments yourself :)
from lua-resty-limit-traffic.
@agentzh, sure, I would prefer not to reinvent stuff :)
But everything (logic under limit_req.incoming()
as I described), preferably, should take place within a ngx_shmtx_lock
section.
For sliding window I do need the queue. Did you mean adding this functionality to shared_dict list api ?
from lua-resty-limit-traffic.
@alonbg the standard lua_shared_dict implementation in ngx_http_lua_module already supports lists (or queues). Check it out to see if it fits your needs.
from lua-resty-limit-traffic.
@agentzh, for my case, using lua_shared_dict lists might cause a race condition. Well, I can use the lua lock API but there would be an overhead if used for every request. Actually, better to think of it as a special kind of rolling incr
, which is initialized with window, resolution and an optional max value (being the max sum of all queue elements ). The data structure behind is the queue and the timestamp. I think I'll go forward with the c-api separate modul option and if it's generic enough you could consider it later on for ngx_http_lua_model.
Thanks
from lua-resty-limit-traffic.
Related Issues (20)
- How to share limit information among nodes? HOT 1
- req limit HOT 4
- resty.limit.req vs resty.limit.count HOT 2
- when using "resty.limit.req" to control rate, actual request processing rate might exceed configured rate. HOT 5
- Why the traffic limit requires two limit_req HOT 1
- prefer HTTP_TOO_MANY_REQUESTS over HTTP_SERVICE_UNAVAILABLE HOT 1
- Limit breaches significantly as we increase traffic
- Reset is not working with count.md code
- Question about race condition in 'count' limiter ('not found' error)
- limit.req with ngx.now HOT 1
- limit_conn.new("my_conn_store", 1000, 1000, 0.5) How to understand 0.5?
- Limiting Website
- limit_req is not as expected in openresty/1.15.8.2 HOT 2
- Is there any performance issue if every request interact with ngx.shared.dict HOT 1
- ngx.ctx with ssl_certificate_by_lua HOT 2
- A question about limit_conn HOT 1
- Q: What advantages does this library hold over Nginx's built-in rate limiting currently?
- Rate-Limit Per Minute HOT 1
- Rate limit status headers
- [p0][conn-limit]blocked all traffic HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lua-resty-limit-traffic.