GithubHelp home page GithubHelp logo

Comments (5)

Jakob3xD avatar Jakob3xD commented on August 17, 2024

@martingrzzler thanks for the report.
It is possible for you to test this with the main branch.
I did some changes to the error handling and it should now cover more cases. See error.go.
If this does not help, then please provide the 429 reponse body you get so we can adjust or add some error struct.

from opensearch-go.

martingrzzler avatar martingrzzler commented on August 17, 2024

@Jakob3xD

If I'm not mistaken the 429 Error will be mapped to ErrNonJSONError. I've tried the following test:

{
				Name: "Too many requests",
				Resp: &opensearch.Response{
					StatusCode: http.StatusTooManyRequests,
					Body:       io.NopCloser(strings.NewReader("429 Too Many Requests /testindex/_bulk")),
				},
				WantedErrors: []error{opensearch.ErrNonJSONError},
},

Perhaps a ErrTooManyRequests should be added to the sentinels?

	ErrUnauthorized           = errors.New(http.StatusText(http.StatusUnauthorized))
        ErrTooManyRequests    = errors.New(http.StatusText(http.TooManyRequests))

from opensearch-go.

dblock avatar dblock commented on August 17, 2024

@martingrzzler Yes, it should. Want to contribute a test + fix?

from opensearch-go.

Jakob3xD avatar Jakob3xD commented on August 17, 2024

Adding this for now is okay but maybe instead of doing:

	if !json.Valid(body) {
		if resp.StatusCode == http.StatusUnauthorized {
			return ErrUnauthorized
		}
		return ErrNonJSONError
	}

We can do:

	if !json.Valid(body) {
		return fmt.Errorf("%w, %s",ErrNonJSONError, body )
	}

Or even omit the ErrNonJSONError from the error. I am not sure how good this will scale if we have some more error codes that have a non json response on error.

from opensearch-go.

martingrzzler avatar martingrzzler commented on August 17, 2024

@Jakob3xD I've went with the approach you suggested without the ErrNonJSONError.

from opensearch-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.