Support for disconnecting a cluster from Hive wihout de-provisioning it about hive

[jhernand]

CC @zgalor @tzvatot

[dgoodwin]

It'll be supported if you need it yes. :) @csrwng what do you think is the safest way to do this? I'm nervous about deleting the finalizer, a mistake and it's bye bye cluster. Deleting the AWS creds before deleting the finalizer, and then the cluster, might be a good safety net as deprovision wouldn't be able to do anything then even if it did trigger.

[csrwng]

@dgoodwin an alternative would be to add an annotation to the cluster to indicate that it's disconnected, or even a field in the clusterdeployment spec (I think I like the field better). That way we know to discontinue any syncs and not run the delete.

[jhernand]

I like the idea of the field, as it is self-documented in the code of the API, it is a better contract.

[dgoodwin]

Filed in https://jira.coreos.com/browse/CO-153

[dgoodwin]

@ShivamChamoli this is a good one to start.

Basically adding a new field to ClusterDeployment in clusterdeployment_types.go, and then going into the cluster deployment controller and using that field to determine if we should launch the uninstall job or not.

[dgoodwin]

In progress via Shivam.

[dgoodwin]

https://jira.coreos.com/browse/CO-153