Comments (8)
from hive.
It'll be supported if you need it yes. :) @csrwng what do you think is the safest way to do this? I'm nervous about deleting the finalizer, a mistake and it's bye bye cluster. Deleting the AWS creds before deleting the finalizer, and then the cluster, might be a good safety net as deprovision wouldn't be able to do anything then even if it did trigger.
from hive.
@dgoodwin an alternative would be to add an annotation to the cluster to indicate that it's disconnected, or even a field in the clusterdeployment spec (I think I like the field better). That way we know to discontinue any syncs and not run the delete.
from hive.
I like the idea of the field, as it is self-documented in the code of the API, it is a better contract.
from hive.
Filed in https://jira.coreos.com/browse/CO-153
from hive.
@ShivamChamoli this is a good one to start.
Basically adding a new field to ClusterDeployment in clusterdeployment_types.go, and then going into the cluster deployment controller and using that field to determine if we should launch the uninstall job or not.
from hive.
In progress via Shivam.
from hive.
https://jira.coreos.com/browse/CO-153
from hive.
Related Issues (20)
- hive upgrade to 1.1.6 is expecting CRD API version to be v1beta instead of v1 HOT 5
- Ability to Override httpCustomErrorCodePages in ClusterDeployment HOT 7
- Implement Openstack Hibernation HOT 9
- Pass skip_provider_registration flag HOT 2
- How to make Hive trust new API cert in managed cluster? HOT 6
- Hive Cluster Relocation is stuck on kube-root-ca.crt and openshift-service-ca.crt already exists HOT 5
- Rotating the admin kubeconfig after 10 years HOT 6
- Install fails on ClusterRoleBinding HOT 7
- Consider tagging submodule "apis"? HOT 2
- How if Hive released? HOT 1
- ClusterClaim-controller should watch for changes to RoleBindings as well HOT 1
- ClusterSync-controller's requeueAfter duration could be insufficient HOT 2
- Availability of Hive in ARM HOT 5
- hive-clustersync-0 - CreateContainerConfigError
- Provided SSH keypair not used for bootstrap node HOT 11
- Add IBM resource group flag in hiveutil HOT 3
- Missing Role and/or RoleBinding block clustercleanup HOT 4
- How to troubleshoot clusterpools? HOT 2
- Dependency Dashboard
- Deleting an adopted cluster does not remove cluster from hive HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hive.