GithubHelp home page GithubHelp logo

Comments (5)

dgoodwin avatar dgoodwin commented on July 29, 2024

Admin kubeconfig too.

from hive.

joelddiaz avatar joelddiaz commented on July 29, 2024

What do we do in the case where there is an existing configmap/secret? Trash/replace?

from hive.

dgoodwin avatar dgoodwin commented on July 29, 2024

I think they fall into the same bucket as the cleanup before install, so yeah I'd trash them if they exist and we're runinng a new install job.

from hive.

joelddiaz avatar joelddiaz commented on July 29, 2024

after discussion the plan is to:

  1. detect any pre-existing secret/configmap and delete
  2. 10 retries to fetch/store the admin kubeconfig (this is considered a critical failure)
  3. best effort to save the installer's metadata file
  4. update the clusterdeployment status with the secret name holding the admin kubeconfig (non-critical as it will be updated during normal controller reconciliation)

from hive.

joelddiaz avatar joelddiaz commented on July 29, 2024

fixed with #92

from hive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.