libvirt install: Network created with static dhcp assignments, why? about installer

[wking]

Can you provide more detail, I'm having trouble parsing "static dhcp" ;). Maybe you mean our static IPs? We don't really care what the IPs are, but it seems like users won't care either. Is your issue just "we should drop those at some point" and not a "this is breaking $WORKFLOW"?

Also, for our cloud systems we push up masters and workers in separate subnets, which we don't bother with for libvirt. I don't see that changing, but we could obviously revisit that if someone raises a use-case where it would matter.

[michaelgugino]

I'm having trouble parsing "static dhcp"

I mean exactly that. DHCP on libvirt is configured to provide static-only IP assignments, not from a pool.

Relevant config:

[root@mguginop50 ~]# cat /var/lib/libvirt/dnsmasq/tectonic.conf 
##WARNING:  THIS IS AN AUTO-GENERATED FILE. CHANGES TO IT ARE LIKELY TO BE
##OVERWRITTEN AND LOST.  Changes to this configuration should be made using:
##    virsh net-edit tectonic
## or other application using the libvirt API.
##
## dnsmasq conf file created by libvirt
strict-order
local=/tt.testing/
domain=tt.testing
expand-hosts
pid-file=/var/run/libvirt/network/tectonic.pid
except-interface=lo
bind-dynamic
interface=tt0
dhcp-range=192.168.122.1,static
dhcp-no-override
dhcp-authoritative
dhcp-hostsfile=/var/lib/libvirt/dnsmasq/tectonic.hostsfile
addn-hosts=/var/lib/libvirt/dnsmasq/tectonic.addnhosts

[root@mguginop50 ~]# virsh net-dumpxml tectonic
<network connections='4'>
  <name>tectonic</name>
  <uuid>34300328-11b3-4dbb-ab76-dcd1e52886d4</uuid>
  <forward mode='nat'>
    <nat>
      <port start='1024' end='65535'/>
    </nat>
  </forward>
  <bridge name='tt0' stp='on' delay='0'/>
  <mac address='52:54:00:bb:79:58'/>
  <domain name='tt.testing' localOnly='yes'/>
  <dns>
    <host ip='192.168.122.10'>
      <hostname>mgugino-test-api</hostname>
    </host>
    <host ip='192.168.122.11'>
      <hostname>mgugino-test-api</hostname>
      <hostname>mgugino-test-etcd-0</hostname>
    </host>
    <host ip='192.168.122.50'>
      <hostname>mgugino-test</hostname>
    </host>
  </dns>
  <ip family='ipv4' address='192.168.122.1' prefix='24'>
    <dhcp>
      <host mac='5e:f3:a7:15:ce:5d' name='mgugino-test-master-0' ip='192.168.122.11'/>
      <host mac='5a:c0:c4:e9:62:ba' name='mgugino-test-bootstrap' ip='192.168.122.10'/>
      <host mac='da:68:1d:0d:86:d1' name='worker-sdb9x' ip='192.168.122.51'/>
    </dhcp>
  </ip>
</network>

Compare those to libvirt's default network configuration, you'll see what I mean. There's no need to statically code dhcp entries, just use an IP range.

My use case is getting old installer to work with new via scaleup (part of my 4.0 deliverable). While I can work around this issue, it does add extra steps and it's just weird that it would be this way by default.

[dustymabe]

maybe related: #708

[crawford]

I believe this is an artifact of the way the old (Tectonic) installer worked. Now that we use DNS to resolve the hosts, there shouldn't be any need for static assignments. We could try removing these, but it doesn't feel like a high priority at the moment.

[zeenix]

/priority backlog

[zeenix]

/assign

[abhinavdahiya]

@zeenix is this still something you are looking at?

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.