Compile errors after rev 564. about libopenshot

[ferdnyc]

Very belated PR submitted at OpenShot/libopenshot-audio#19, when that's merged this can finally be closed. (Shutting the barn door after the horses are gone, as they say, now that libopenshot-0.2.0 is already released. But, oh well.)

[joebonrichie]

Also getting this error on Solus, is there something obvious i'm missing?

[joebonrichie]

Just an FYI had to rebuild with ruby bindings disabled -DENABLE_RUBY=OFF to compile. Can provide more details if this gets any attention.

[ferdnyc]

I just hit this myself, compiling with gcc 7.3.1 on Fedora 27.

The issue, surprisingly enough, is actually in libopenshot-audio, specifically one of the macros in its header files that libopenshot includes.

I do not even remotely pretend to understand why this fixes the issue or even makes a difference, but the same bug was reported over at open-source-parsers/jsoncpp#214, and a comment there pointed me at the fix.

Here's a diff rooted in the libopenshot-audio-0.1.5 source tree, that shows the fix:

diff -u JuceLibraryCode/modules/juce_core/maths/juce_MathsFunctions.h.orig JuceLibraryCode/modules/juce_core/maths/juce_MathsFunctions.h
--- JuceLibraryCode/modules/juce_core/maths/juce_MathsFunctions.h.orig	2018-02-21 03:54:09.141547407 -0500
+++ JuceLibraryCode/modules/juce_core/maths/juce_MathsFunctions.h	2018-02-21 03:54:36.394066259 -0500
@@ -381,7 +381,8 @@
    #if JUCE_WINDOWS && !JUCE_MINGW
     return _finite (value) != 0;
    #else
-    return std::isfinite (value);
+    using namespace std;
+    return isfinite (value);
    #endif
 }
 
@@ -391,7 +392,8 @@
    #if JUCE_WINDOWS && !JUCE_MINGW
     return _finite (value) != 0;
    #else
-    return std::isfinite (value);
+    using namespace std;
+    return isfinite (value);
    #endif
 }
 

Like I said, I don't pretend to understand why that works (I'm not a C++ guy), but if libopenshot-audio is built and installed with the headers patched in that way (or if the headers are manually modified post-install, which is how I originally tested the change), then libopenshot will compile successfully.

(If you're using the libopenshot-0.1.5.tar.gz release code, though, you also need to apply the fix from pull request #67 in this repo.)

[ferdnyc]

Closed with OpenShot/libopenshot-audio#37