Comments (10)
@simonpoole Anything still to do here?
from osm-binary.
Yes, this weekend (likely).
from osm-binary.
@simonpoole ping?
from osm-binary.
I was actually thinking on working on it when I get back next week.
from osm-binary.
Hello @joto I am a new contributor
I saw this open issue
can you share the base branch, I will create a PR from "Fix_OSMHeader_block_compression" to the base branch
Also @simonpoole is there any channel I can join to be in sync with the issues and project updates?
from osm-binary.
I was actually thinking on working on it when I get back next week.
Hmm this wasn't actually the issue I was thinking about when I wrote that. Anyway @divyanshuagarwal-23 this wouldn't really seem to be a good beginner issue, but by all means feel free to to port the PR if it is even still necessary.
from osm-binary.
@simonpoole I would like to work on the core codebase of OSM-binary, and need initial mentorship
please help me with this
from osm-binary.
Do you have any slack channel that I joining and learn
from osm-binary.
If I understand this issue correctly it is about the OSMHeader
file block that should not be compressed. But there is only one place where we create such a file block and that is in a test file where compression is set to null
. So I don't see how we can apply this patch from Osmosis here!?
@simonpoole Did I misunderstand something here? Can we close this?
from osm-binary.
Sigh, the confusion lies here openstreetmap/osmosis#109 (comment)
When I saw @brettch comment I mistakenly assumed he had removed all vendored bits wrt pbf handling. But that only applies to osmosis-osm-binary and not osmosis-pbf (which is the bit that writes OSMHeader file blocks).
So the only change necessary -here- is the mini change to expose the CompressFlag enum so that it can be used in the osmosis package. See https://github.com/openstreetmap/osmosis/pull/109/files#diff-e98fe772c729b5020654d4563dcb3c03bdf132f91a351adcd3a39467262bb0cb
I'll create a PR today or tomorrow. Sorry for the confusion.
PS: it could be argued that this was always a bug as the public method BlockOutputStream.write(FileBlock block, CompressFlags compression) references the only package level visible CompressFlags.
from osm-binary.
Related Issues (20)
- What is your attitude towards putting the Java version into Maven Central? HOT 14
- Can't create osmbpbf.jar on OSX using install instructions for ant HOT 3
- Update protocol buffers version in pom HOT 1
- protobuf.jar HOT 1
- Inconsistent type of roles_id in message Relation? HOT 1
- port to yocto HOT 1
- which protobuf library does this use? HOT 2
- Where is Osmformat class?
- Github action warning HOT 1
- Create GitHub release for 1.4.0 Java version HOT 1
- osm-pbf 1.4.0 OSX build issue HOT 8
- CMake build doesn't respect CMAKE_INSTALL_LIBDIR HOT 1
- CMake build doesn't configure SOVERSION for library HOT 2
- add_subdirectory given source "osmpbf" which is not an existing directory HOT 2
- C++ compilation requires C++ 11
- error: use of undeclared identifier 'isatty'
- blob-header-size is bigger then allowed HOT 1
- Android application for boat navigation HOT 2
- Add support for Protobuf 22+ which can require either C++14 or C++17 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osm-binary.