hd.c:2697:3: error: 'for' loop initial declarations are only allowed in C99 mode about hwinfo

[linuxhw]

@wfeldt Please look

[wfeldt]

It's a bit hard, 'modern' C features just creep in.

What's wrong with an explicit -std=gnu99? I've seen no issues when I tried it.

[linuxhw]

It's:

+ cd hwinfo-21.80
+ make 'LDFLAGS=-Wl,-z,relro  -Lsrc' CFLAGS=-std=gnu99 LIBDIR=/usr/lib64 HWINFO_VERSION=21.80
make[1]: Entering directory `/builddir/build/BUILD/hwinfo-21.80/src'
make[2]: Entering directory `/builddir/build/BUILD/hwinfo-21.80/src/hd'
make[2]: Leaving directory `/builddir/build/BUILD/hwinfo-21.80/src/hd'
make[2]: Entering directory `/builddir/build/BUILD/hwinfo-21.80/src/hd'
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc bios.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc block.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc braille.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc cpu.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc drm.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc dvd.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc edd.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc fb.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc floppy.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc hal.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc hd.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc hddb.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc hdp.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc input.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc int.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc isa.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc isapnp.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc isdn.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc kbd.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc klog.c
cc -c -std=gnu99  -Wl,-z,relro  -Lsrc manual.c
manual.c:24:27: fatal error: hwclass_names.h: No such file or directory
 #include <hwclass_names.h>
                           ^
compilation terminated.
make[2]: *** [manual.o] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/hwinfo-21.80/src/hd'
make[1]: *** [subdirs] Error 2
make[1]: Leaving directory `/builddir/build/BUILD/hwinfo-21.80/src'
make: *** [subdirs] Error 2

See https://koji.fedoraproject.org/koji/taskinfo?taskID=85439747

[linuxhw]

Let's forget about this. This is not critical. We have CentOS 8 and CentOS 9 already, where I have successfully upgraded hwinfo to 21.80. Let's leave 21.68 in CenOS 7 - not tried higher versions.