Comments (3)
Not sure - I think the role of this library is just to propagate the trace context, not to assume that a span should exist. If the application wants some form of bounding scope/span, then they should ensure it is created through other instrumentations or explicitly by the application itself.
from java-concurrent.
Executors are usually used for time-consuming tasks, therefore having a span which wraps the whole invocation helps you to understand latency problems. Not even saying that In some situations, there won't be parent span (e.g. no servlet environment) in this situation this library does not bring you any value. A specific use case is Executor instrumentation in Spring. It can be used without web package.
Creating a span should be optional. It would be a boolean flag in executor constructor whether to create a span or not.
from java-concurrent.
fixed via #13
can be closed now
from java-concurrent.
Related Issues (11)
- Additional documentation HOT 3
- Instrumenting ForkJoinPool
- ongoing span relationships with jobs that repeat jobs HOT 2
- use TracedExecutorService occur OOM HOT 2
- ClassCastException with Slick HOT 1
- The trace context does not propagate to the callback of ThreadPoolTaskExecutor/Scheduler HOT 1
- Can you show some scenarios when to using java-concurrent tracing? HOT 1
- exceptions are not logged
- How to pass parent context with TracedExecutor Service HOT 3
- Can byteman be used to automatically wrap executors? HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from java-concurrent.