Global JAEGER_TAGS environment variable is not used by spring starter. about java-spring-jaeger

[geoand]

Why not to provide tags as map via spring config?

I don't see a way to provide a map of Tags via application.yml/Spring Config.

I think supporting both JAEGER_TAGS + a map from application.yml might be good!

That's pretty much what the PR does 😉

[ledor473]

Oh I missed that part. That's indeed what it does :)

[mwenk-cc]

PR for this: #17

[mwenk-cc]

Close PR as intended solution had issues.

The spring starter should use environment variables if environment variables are there. So this issue is still open from that perspective.

[geoand]

I will look into JAEGER_TAGS but I don't agree that the env vars should be used if they are there.
If the user wanted that, they could just go ahead and use declare a bean from Configuration.fromEnv().getTracerBuilder().
Having said that I will look into ways to provide even more configuration

[pavolloffay]

Why not to provide tags as map via spring config?

[geoand]

@pavolloffay Thanks for the suggestion, I plan to look into this soon

[sagaranand015]

@geoand: Any update on this please?
We have a use case to inject the JAEGER_TAGS values from environment, so looking around for this support.
Thanks a ton!

[geoand]

@sagaranand015 I just created #36 to address this

[sagaranand015]

This is lovely!
Eagerly waiting for it be to be merged and released. Thank you @geoand

[geoand]

You're welcome!

Once I get a review, I'll merge and do a release

[ledor473]

Why not to provide tags as map via spring config?

I don't see a way to provide a map of Tags via application.yml/Spring Config.

I think supporting both JAEGER_TAGS + a map from application.yml might be good!

[geoand]

Version 1.0.2 is on the way with a fix on this