GithubHelp home page GithubHelp logo

Comments (13)

geoand avatar geoand commented on July 17, 2024

Could you provide (a lot) more information about the problem please and possible a reproducer project?

from java-spring-jaeger.

shurdsfield avatar shurdsfield commented on July 17, 2024

Steps to create issue

  • I add tracing to an existing webflux project
  • that project uses WebClient to call another service
  • That response contains invalid headers (or anything that causes an exception)

The result is that there is an exception, but there is no response written and the request hangs without ever terminating

If i remove the tracing dependancy everything works ok and i get a response
I have attached a sample.

just go to http://localhost:8080/hello

spring-cloud-tracing-bug-2.tar.gz

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

I see that you are using a milestone version of Spring Boot. We certainly haven't tested with any such version so it is no surprise that it doesn't work.
Do you see the same behevior if you use the latest release version of Spring Boot?

from java-spring-jaeger.

shurdsfield avatar shurdsfield commented on July 17, 2024

yes, i only tried that to make sure it wasnt a defect that had been fixed but yes changing version makes no difference

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

OK, thanks. I will take a look hopefully soon.

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

@shurdsfield I just tried your reproducer (albeit with Spring Boot 2.1.6.RELEASE) and the /hello endpoint worked without issues.
Can you confirm or is there something missing?

from java-spring-jaeger.

shurdsfield avatar shurdsfield commented on July 17, 2024

i am using jdk : openjdk 11.0.2
and running
./gradlew bootRun

Just tried now and get the exception

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

It worked perfectly for me, here is the last part of the output:

2019-06-21 14:07:22.680  INFO 9373 --- [or-http-epoll-2] i.j.internal.reporters.LoggingReporter   : Span reported: b2a4f8c7b7b087ec:b2a4f8c7b7b087ec:0:1 - hello

The output of ./gradlew -version for me is:

------------------------------------------------------------
Gradle 5.4.1
------------------------------------------------------------

Build time:   2019-04-26 08:14:42 UTC
Revision:     261d171646b36a6a28d5a19a69676cd098a4c19d

Kotlin:       1.3.21
Groovy:       2.5.4
Ant:          Apache Ant(TM) version 1.9.13 compiled on July 10 2018
JVM:          11.0.2 (Oracle Corporation 11.0.2+9)
OS:           Linux 4.18.0-22-generic amd64

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

I also tried with java -jar .... after building with ./gradlew build and same result, the endpoint responsed properly

from java-spring-jaeger.

shurdsfield avatar shurdsfield commented on July 17, 2024

Ok, so it just when using the 2.2 milestone releases i have the issue. I thought id tried with 2.1 release versions but maybe i was mistaken. something to keep an eye on with the next release

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

Awesome, thanks @shurdsfield for inverstigating.

I will go ahead and close this issue for the time being and we can reopen if there is a problem with the released of version of 2.2.x

from java-spring-jaeger.

shurdsfield avatar shurdsfield commented on July 17, 2024

Just to add i am blocked since #50 means i cant upgrade to 2.1.6. if i downgrade to io.projectreactor.netty:reactor-netty:0.8.6.RELEASE to fix #50 i get the exception again

from java-spring-jaeger.

geoand avatar geoand commented on July 17, 2024

So it looks like reactor-netty is doing something weird... I guess we just have to wait and see what happens

from java-spring-jaeger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.