Comments (3)
Hi, patrice. It is probably the case that java 6 requires only this change. can you temporarily stick in animal sniffer to confirm? (after setting target level)
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
<version>1.15</version>
<configuration>
<signature>
<groupId>org.codehaus.mojo.signature</groupId>
<artifactId>java16</artifactId>
<version>1.0</version>
</signature>
</configuration>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
from opentracing-java.
Hi @adriancole,
after checking your code, I'm actually very confused now. You have the animal sniffer already in there, and I saw that you even have the definition in the pom.xml of the API project like this:
<properties>
<main.basedir>${project.basedir}/..</main.basedir>
<main.java.version>1.6</main.java.version>
<main.signature.artifact>java16</main.signature.artifact>
</properties>
The main.signature.artifact
definition is used by the animal sniffer to check against java 1.6. My guess currently is that animal sniffer does not take the implementing of the AutoCloseable into account somehow. This is the output of the plugin:
[INFO] Building OpenTracing API 0.20.2
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- animal-sniffer-maven-plugin:1.15:check (default-cli) @ opentracing-api ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.0
[INFO]
Could it be that you want the API to be 1.6 compatible in the first place as defined in the pom? That would be perfect for us 😄
from opentracing-java.
This ticket has been solved by 28d8616 .
from opentracing-java.
Related Issues (20)
- Why doesn't Span support try-with-resources? HOT 4
- Docs reference outdated API HOT 3
- Correct way how to not report fast spans HOT 12
- Unit tests fail with "AbstractMethodError" HOT 2
- Access Custom Tracer's fields through GlobalTracer.get() HOT 4
- Overriding timestamp on spans HOT 3
- TextMapInjectAdapter does not implement TextMap HOT 1
- Not able to get simple opentracing code to work HOT 3
- Missing ScopeManager.active() method HOT 1
- `NoopSpan` cannot be used as a default, parent span without throwing Exception. HOT 6
- try-with-resources (which doesn't work) is still the main documented way to use OpenTracing in java
- Breaking change from 0.31 to 0.33 HOT 6
- TracingKafkaConsumer incompatible with Kafka >= 2.4.0 HOT 1
- access to registered tracer
- Migrating the CI CD from Travis to GitHub Actions HOT 4
- Are there version mappings to OpenTracing Specification?
- Span object is null when passing RequestEntity<?> as a request parameter
- Possible to terminate span on remote system? HOT 2
- State of opentracing-java HOT 1
- Why are some tags missing in the releases? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentracing-java.