GithubHelp home page GithubHelp logo

Comments (9)

da115115 avatar da115115 commented on June 25, 2024 1

Added a file, contributed by @aseredyn:
optd_city_timezone-2016-05-02-AS.xlsx

Some context:

  • There are cases of different time zone references for the same city. For instance, Odessa airport (ODS, “A”) is in a different time-zone than Odessa city (ODS, “C”).
  • There are more cases, referenced in the above Excel sheet (there are only cases with env_id=="" && !is.na(page_rank) && !is.na(gmt_offset)).
  • There are plenty other cases, where some bus station or outdated airport in a given city has some other (or missing) time-zone info than the main one in the city. Those are ignored in this quick check.
  • In some cases, the time-zone label is different (e.g., "A, VSA, America/Merida" vs. "C, VSA, America/Mexico_City"). But, in some other cases, the time-zone (and hence GMT offset) is different (like in the case of ODS). In the Excel, those are marked in the “diff_offset” column.
  • The numbers of scheduled flights of full 2015 are also provided, so as to sort by the most relevant ones.

from opentraveldata.

da115115 avatar da115115 commented on June 25, 2024

Thanks!

Could you please provide a pointer to your script?

from opentraveldata.

alexprengere avatar alexprengere commented on June 25, 2024

For more context see opentraveldata/optd#31, the actual script is here.

from opentraveldata.

tadhgpearson avatar tadhgpearson commented on June 25, 2024

+1 for this, it's breaking our timezone import.
I'd encourage you to start by removing the clearly fake places, such as HDQ, VVV, NNN and IAT with no timezone, let me know if there's an obvious way I can help you with that.

from opentraveldata.

da115115 avatar da115115 commented on June 25, 2024

There are still a lot of POR with time-zone issues. Almost all of them are now reported in a new CSV file: opentraveldata/optd_por_tz_wrong.csv. However, none of them appear in flight schedules (their PageRank values are null); so, if you filter the null-PageRank POR, you shouldn't have any issue any more.

Those POR correspond to entries appearing in reference data, but not in OpenTravelData.

  1. Some of the POR are missing, and should be added to OpenTravelData. For that, add the corresponding entries in opentraveldata/optd_por_best_known_so_far.csv.
  2. Some others are invalid, and must be filtered out. For that, just add entries in opentraveldata/optd_por_ref_exceptions.csv.

from opentraveldata.

tadhgpearson avatar tadhgpearson commented on June 25, 2024

Thanks for the clarification Denis. However, it's still not clear to me - do all cities / airports in the optd_por_public file require a timezone? Should we be adding those that don't have a timezone to the exceptions list so that they are not included in the output?

from opentraveldata.

da115115 avatar da115115 commented on June 25, 2024

There is no such thing as a file "requiring" a valid time-zone; whereas you, as a user, may require a valid time-zone. If that is the case (and I fully understand that it would be the case!), then a quick work around is to filter out the records having no PageRank value.
On the longer term, we should add to Geonames the missing POR. Then, once the POR are in Geonames, the time-zone will automatically be valid.

from opentraveldata.

da115115 avatar da115115 commented on June 25, 2024

All the time-zone errors have been fixed.
See also opentraveldata/optd_por_tz_wrong.csv.

from opentraveldata.

alexprengere avatar alexprengere commented on June 25, 2024

I confirm that all timezones are now valid! Thanks Denis!

from opentraveldata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.