Comments (2)
I've fixed this specific issue in the commit mentioned above, but I based it on a branch already containing my PRs #20, #21 and #22.
There will be some merge conflicts if we merge them one by one, so before sending a PR for this, I wanted to check if it would be better to send a new PR that combines all the fixes in one PR, or would you rather merge the other PRs first and then have me rebase off that?
from bananas-frontend-cli.
What I commonly do, is make the PR with the others included, and stating that in the Pull Request (something like: include #.., #.., etc). That means for the reviewer it is clear in which order he should review the stuff, and makes sure you don't have to make your life very complicated :D
Also poke to reviewers to get a move on :P
from bananas-frontend-cli.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bananas-frontend-cli.