GithubHelp home page GithubHelp logo

Comments (17)

siddhant-0707 avatar siddhant-0707 commented on September 27, 2024 1

.take

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024 1

@p-wysocki @vshampor I've created a PR #2637

from nncf.

github-actions avatar github-actions commented on September 27, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

from nncf.

tvilight4 avatar tvilight4 commented on September 27, 2024

@vshampor missed this!! will wait for the next one!! thanks for informing!!

from nncf.

vshampor avatar vshampor commented on September 27, 2024

@tvilight4 I have created #2491 now, take a look.

from nncf.

tvilight4 avatar tvilight4 commented on September 27, 2024

@vshampor thanks!! got assinged for it.
will start working on the same

from nncf.

p-wysocki avatar p-wysocki commented on September 27, 2024

Hello @tvilight4, are you still working on that issue or can we reassign it?

from nncf.

p-wysocki avatar p-wysocki commented on September 27, 2024

@vshampor could you please either link the PR to the development section of the issue or grant me some permissions in NNCF repo to do this myself?

image

I'd prefer the latter since I'm keeping an eye on all GFIs weekly.

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024

@p-wysocki Is this issue being actively worked on? If not, I'm down to work on it!

from nncf.

p-wysocki avatar p-wysocki commented on September 27, 2024

Hi @anzr299, sure! The thing is this issue is in NNCF repository and I do not have correct access rights to assign you. @vshampor could you please do it?

For now let's agree the task is yours, feel free to start working on it and ask questions. We'll figure out the formalities in the background. :)

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024

Sure, thank you very much! I have already started working on it.

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024

Hi @p-wysocki, what is the update regarding the assignment? I was off for some time due to my dissertation submission. I am resuming work on this issue now.

from nncf.

p-wysocki avatar p-wysocki commented on September 27, 2024

Done, please let us know if you have any questions @anzr299. :)

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024

Sure, I am following the current types that are mentioned in some files. For arguments with kwargs and args, I am planning on using "...", is that fine?

from nncf.

p-wysocki avatar p-wysocki commented on September 27, 2024

I found some good tips here, I think you can pick one you'd like to use and it's going to be fine - worst case scenario we'll change it.

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024

Also, I was wondering if the the | method would be preferred over the Optional() method to denote an option between type and None since the latest updates suggest a movement towards the | direction but the current NNCF code mostly uses optional().

from nncf.

anzr299 avatar anzr299 commented on September 27, 2024

I am facing a problem in the following section of training_loop.py:
image
Mypy is giving an error saying the CompressionScheduler doesn't contain current_sparsity_level and current_pruning_level. A similar problem exists in the _interpolate_compression_step_update method for runner.maximal_accuracy_drop.

from nncf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.