QProcess::start: Process is already running about johnny

[mathsoft-dev]

This piece of code(from method callJohnShow) doesn't work as we thought :
1.if (m_johnShow.state() != QProcess::NotRunning)
2. m_johnShow.stop();
.....
3. m_johnShow.start();
In fact, it doesn't seem to protect us. Imagine the use case described in the first post, m_johnShow.state() == QProcess::Starting before we call m_johnShow.stop(). However, it is probably stopped asynchronously, because, before starting johnShow again(line 3), m_johnShow is still in the Starting state as the debugger shows. It is NOT stopped yet which gives the warning on the terminal.

[mathsoft-dev]

JohnHandler::terminate(bool) wasn't doing anything to terminate the process for the case QProcess::Starting. Fixed in 6bc896d.

[shinnok]

How about we also don't call johnShow if johnAttack exited with error status?

[mathsoft-dev]

How about we also don't call johnShow if johnAttack exited with error status?

Okay, I'll make the change

[mathsoft-dev]

Fixed.