Comments (5)
This piece of code(from method callJohnShow) doesn't work as we thought :
1.if (m_johnShow.state() != QProcess::NotRunning)
2. m_johnShow.stop();
.....
3. m_johnShow.start();
In fact, it doesn't seem to protect us. Imagine the use case described in the first post, m_johnShow.state() == QProcess::Starting before we call m_johnShow.stop(). However, it is probably stopped asynchronously, because, before starting johnShow again(line 3), m_johnShow is still in the Starting state as the debugger shows. It is NOT stopped yet which gives the warning on the terminal.
from johnny.
JohnHandler::terminate(bool) wasn't doing anything to terminate the process for the case QProcess::Starting. Fixed in 6bc896d.
from johnny.
How about we also don't call johnShow if johnAttack exited with error status?
from johnny.
How about we also don't call johnShow if johnAttack exited with error status?
Okay, I'll make the change
from johnny.
Fixed.
from johnny.
Related Issues (20)
- error: ‘>>’ should be ‘> >’ within a nested template argument list HOT 2
- problem in Johnny 2.2 HOT 2
- Johnny detects far less hash types than John The Ripper HOT 3
- MPI cluster support HOT 2
- CRC Errors whenever I try to unzip 2.1 or 2.2 HOT 3
- Supporting partial passphrase inputs
- Installation problems under Ubuntu 18.04.4 LTS HOT 3
- Installation under Ubuntu 18.04.4 LTS HOT 37
- Test with latest Qt 5
- Platform tests
- Test dark-mode switching on macOS and Windows
- Add snapcraft support for Johnny
- Update UI to 2020
- Homebrew formula
- Corrupt file: Binary v2.2 for windows 64 bit HOT 2
- No file pdf2john.py HOT 1
- Where is actual John The Ripper? HOT 1
- The README file doesn't render in GitHub General Markdown format
- No 7z2john.py HOT 1
- DMG file password recovery HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from johnny.