GithubHelp home page GithubHelp logo

make layout great again about asu HOT 23 CLOSED

openwrt avatar openwrt commented on June 15, 2024 3
make layout great again

from asu.

Comments (23)

aparcar avatar aparcar commented on June 15, 2024 1

Pull Requests?

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

@aparcar wrote:

It looks a bit better on the official bootstrap version, but feel free to add design suggestions :)

from asu.

aparcar avatar aparcar commented on June 15, 2024

@egon0 can you help me out?

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

to start with the first page (without clicking the search button):

  • there should be a small description about that package. (see other luci-subpages). of course with translations (at least for german language).

  • button: "search for updates" sounds inconsistent, because the headline and name of the project is "... upgrade"! so the name "updates" isnt nice.. the result of the search is not "many updates", but one "upgrade". you might change the name to "online search" to clarify the online-character of this project

  • the checkbox "Search for package updates": i really do not understand the purpose of that checkbox. also my problem with "updates", while the project does an "upgrade".
    a translation also would be nice. (i8n)
    if that checkbox does something during the "search" it should be ABOVE the search-button, because its an option for that search!? (see other luci-pages)

from asu.

aparcar avatar aparcar commented on June 15, 2024

PRs are welcome πŸ™„ No seriously, I'll look into that

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

when clicking the first button:

  • The message "imagebuilder not ready, please wait" should be in the same style as other luci-pages. please have a look at the layout of "Γ„nderungen werden angewandt".

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

@aparcar first we have to collect the problems by ticketcomments. Press Release (PR) would not be nice for that moment.

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

cite:
"Search for package updates"

so, what does it mean?
and, what would be a nice german translation?

from asu.

aparcar avatar aparcar commented on June 15, 2024

Anwendungsaktualisierungen. however, I'm not sure how to implement translations with JavaScript.

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

so when disabling this checkbox there are older packages but new kernel? i dont get it.

from asu.

aparcar avatar aparcar commented on June 15, 2024

If 17.01.4 receives a package update but no new major 17.01.x release, with the option checked you simply get a new image

from asu.

egon0 avatar egon0 commented on June 15, 2024

Ping 😎

from asu.

aparcar avatar aparcar commented on June 15, 2024

I'm not sure why I can not assign this directly to @egon0 , but he is the person going to solve this πŸ‘

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

see aparcar/luci@9e1728c

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

having a description is nice.

please change that tagging style from 
<p> 
to
<div class="cbi-map-descr">

from asu.

aparcar avatar aparcar commented on June 15, 2024

Please see https://github.com/aparcar/luci/tree/acls for recent changes.

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

please see openwrt/luci#1408 for recent changes.
and @aparcar told me, new layout can be found here https://github.com/aparcar/luci/tree/v2

from asu.

aparcar avatar aparcar commented on June 15, 2024

@FreifunkUFO please excuse the "chaos", v2 was merged in acls as there already existed an PR

from asu.

FreifunkUFO avatar FreifunkUFO commented on June 15, 2024

and see https://github.com/openwrt/packages/pull/4979/files#diff-066cc010efe5ae62f0ca12bfec1e872d but its only for lede-relase (not for lede-trunk)

from asu.

aparcar avatar aparcar commented on June 15, 2024

openwrt/packages#5053

from asu.

aparcar avatar aparcar commented on June 15, 2024

All done in latest luci version, PR is currently pending
openwrt/luci#1437

@FreifunkUFO if translations are necessary please propose a solution, I have no experience with that

from asu.

aparcar avatar aparcar commented on June 15, 2024

@FreifunkUFO ping

from asu.

aparcar avatar aparcar commented on June 15, 2024

Closing this issue due to no response, please reopen if still relevant.

from asu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.