Comments (4)
Otherwise how would you know what token was minted?
Do you mean when you invoke this function off-chain? In that case you would use the Transfer
event, and in fact the return value wouldn't be available.
Or do you have another scenario in mind?
from contracts-wizard.
The contract caller doesn't know the value of the new tokenId that was generated. I'm suggesting an implementation like this:
function safeMint(address to) public onlyOwner returns (uint256) {
uint256 tokenId = _tokenIdCounter.current();
_tokenIdCounter.increment();
_safeMint(to, tokenId);
return tokenId;
}
from contracts-wizard.
can i work on this issue @ericglau
from contracts-wizard.
@EthixLucifer Sure, thanks. You can find development setup steps in the readme.
from contracts-wizard.
Related Issues (20)
- Can't resolve '../openzeppelin-contracts' in `wizard` 0.2.2 HOT 2
- ERC20 Premint field has no upper bound
- Invalid contracts generated for @openzeppelin/contracts 4.9.0 HOT 1
- Use package entry points for core
- Enable ERC20Permit by default HOT 7
- Use token-specific pausable extensions HOT 1
- add required OpenZeppelin Contracts version as a comment ? HOT 1
- Copy to Clipboard not working from docs site HOT 1
- Use Cairo specific highlighting for Cairo 1+
- Provide better feedback in UI when input is invalid
- Add Cairo lang and OZ Contracts versions to generated contracts HOT 4
- [Vanta] Remediate "Low vulnerabilities identified in packages are addressed (Github Repo)" for npm-undici/CVE-2024-24758 HOT 1
- [Vanta] Remediate "Low vulnerabilities identified in packages are addressed (Github Repo)" for npm-undici/CVE-2024-24758 HOT 1
- [Vanta] Remediate "Low vulnerabilities identified in packages are addressed (Github Repo)" for npm-undici/CVE-2024-24758 HOT 1
- Support mixins
- Consider making upgradeability opt out HOT 2
- Support older version of the contracts library. HOT 1
- Support Contracts for Cairo v0.10.0
- Use Hardhat Ignition in downloaded Hardhat development package
- Used named imports for Solidity HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contracts-wizard.