GithubHelp home page GithubHelp logo

Comments (4)

martriay avatar martriay commented on June 2, 2024 1

Specific version > no version

from contracts-wizard.

ericglau avatar ericglau commented on June 2, 2024

For Solidity, we plan to convey semantic versioning for the OZ Contracts version like this:

// SPDX-License-Identifier: MIT
// Compatible with OpenZeppelin Contracts ^5.0.0
pragma solidity ^0.8.20;

@martriay @ericnordelo @andrew-fleming For Cairo, does it make sense to also convey semantic versioning for Cairo lang itself? For example, something like:

// SPDX-License-Identifier: MIT
// Compatible with OpenZeppelin Contracts for Cairo ^0.8.0
// Cairo lang ^2.3.1

(or // Cairo compiler ^2.3.1)

from contracts-wizard.

martriay avatar martriay commented on June 2, 2024

Looks good! Although I'd be very specific with the versions since Cairo is introducing breaking changes even in minor releases. We cannot guarantee compatibility with any future version.

from contracts-wizard.

ericglau avatar ericglau commented on June 2, 2024

@martriay In that case we should either do // Cairo lang 2.3.1 for a specific version (which is slightly misleading if it does work with a newer version of Cairo), or omit the Cairo version. Which would you suggest?

from contracts-wizard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.