GithubHelp home page GithubHelp logo

Comments (3)

benoit74 avatar benoit74 commented on June 24, 2024

Btw, this could be an elegant solution to fix the fact that all dumps currently stored on S3 are still from April 2 and "corrupted"

from zimfarm.

rgaudin avatar rgaudin commented on June 24, 2024

So it's clear for everybody, the watcher didn't pick up the fixed version because we identify a release as a YYYY-MM string given updates are expected every quarter.

This string is computed from the Last-Modified header of the Sites.xml file and compared to the one we stored in S3.
An update within the same month cannot be detected this way.

from zimfarm.

benoit74 avatar benoit74 commented on June 24, 2024

Here the dumps have been updated but the Sites.xml has not been updated at-all, so current watcher behavior is not aligned (anymore) with SE practices.

I suggest to:

  • stop checking the version of "Sites.xml" (we do not care about it indeed)
  • check the Last-Modified header of every individual archive
  • store the whole Last-Modified header in S3 metadata (instead of the simplified version)
  • use this whole Last-Modified header for taking the decision to download the archive again

from zimfarm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.