GithubHelp home page GithubHelp logo

Comments (4)

Cadair avatar Cadair commented on June 17, 2024 1

I fixed this in #36

from connector-matrix.

jacobtomlinson avatar jacobtomlinson commented on June 17, 2024

After thinking about this I'm not sure the Connector API is quite right. There is no compelling reason why an opsdroid pointer should have to be passed on disconnect as the connector should already have a pointer to it stored as an attribute from when it was set up.

See opsdroid/opsdroid#725 for more information on my requested change.

Once this is implemented this issue will no longer be necessary.

from connector-matrix.

jacobtomlinson avatar jacobtomlinson commented on June 17, 2024

As the change will not be in until the next release you may wish to make the change but ensure it is an optional kwarg so that when the API changes again it will not break. You could then remove this when matrix is merged as a core connector.

from connector-matrix.

Cadair avatar Cadair commented on June 17, 2024

This can be closed.

from connector-matrix.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.