Comments (3)
I really like this idea. I've been thinking about other types of responses for a while. For example opsdroid/opsdroid#195 covers sending images to chat clients.
I totally agree with keeping track of the other metadata which comes with the message. Perhaps the whole response should be stored in message.raw_message
or something? This would avoid us having to extend the Message
class each time this crops up in a connector.
I think I would prefer to extend the Message
class with a method called message.react('thumbsup')
which connectors like Slack could then implement. If the connector does not implement it then it simply logs to say is cannot do it and silently fails, similar to your if statement checking if the connector is slack. This approach would mean we could easily add other clients which support reactions in the future and skills wouldn't need slack specific code.
What do you think?
from connector-slack.
I totally prefer to implement react
in the base and don't use lots of ifs (it's always better to use extension 😉)
And I agree too with save the whole raw_message to have the different information that different connectors can use.
So I will start checking if the problem I detected in slacker Reactions.add
is real, and if it is raise an issue there.
Meanwhile, we should open an issue on opsdroid main repository explaining the Message modifications (raw + react).
from connector-slack.
Once opsdroid/opsdroid#442 and opsdroid/opsdroid#443 are done they will need implementing in this connector.
from connector-slack.
Related Issues (9)
- Update for v0.3.0
- Websocket not reconnecting
- Responses should include a thread_ts
- slacker-asyncio it's probably no longer mantained HOT 1
- slack permissions to skills HOT 1
- Add attachment support HOT 5
- error when starting --> TypeError: object Response can't be used in 'await' expression HOT 6
- Cannot connect to channel HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connector-slack.