Incorrect definition for bid_modifier at campaign criterion about google-ads-node

[markoffk]

Hello!
Issue is still appearing in 1.15.

Trying to make such a call:

customer.campaignCriteria.update({
    resource_name: criteriaItem.campaign_criterion.resource_name,
    bid_modifier: 0 as any, // error in typings
});

Producing following error:

TypeError: valueType.startsWith is not a function
    at toProtoValueFormat (/usr/src/app/node_modules/google-ads-node/build/lib/utils.js:101:19)
    at unroll (/usr/src/app/node_modules/google-ads-node/build/lib/utils.js:90:19)
    at Object.convertToProtoFormat (/usr/src/app/node_modules/google-ads-node/build/lib/utils.js:86:26)
    at GoogleAdsClient.buildResource (/usr/src/app/node_modules/google-ads-node/build/lib/client.js:86:41)
    at GrpcClient.buildResource (/usr/src/app/node_modules/google-ads-api/build/grpc.js:121:28)
    at CampaignCriterionService.buildResource (/usr/src/app/node_modules/google-ads-api/build/services/service.js:211:32)
    at CampaignCriterionService.<anonymous> (/usr/src/app/node_modules/google-ads-api/build/services/service.js:69:33)
    at Generator.next (<anonymous>)
    at /usr/src/app/node_modules/google-ads-api/build/services/service.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/app/node_modules/google-ads-api/build/services/service.js:4:12)
    at CampaignCriterionService.serviceUpdate (/usr/src/app/node_modules/google-ads-api/build/services/service.js:59:16)
    at CampaignCriterionService.<anonymous> (/usr/src/app/node_modules/google-ads-api/build/services/campaign_criterion.js:49:25)
    at Generator.next (<anonymous>)
    at /usr/src/app/node_modules/google-ads-api/build/services/campaign_criterion.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/app/node_modules/google-ads-api/build/services/campaign_criterion.js:4:12)
    at CampaignCriterionService.update (/usr/src/app/node_modules/google-ads-api/build/services/campaign_criterion.js:48:16)

[kritzware]

Hi @markoffk, we've just released a hot fix for this in google-ads-node 1.15.2. This change should be upstreamed into google-ads-api within hours of this comment, so make sure to look out for a new release over there. 👍

Let us know if you have any other problems!

[markoffk]

@kritzware Thanks! It works now.