ResourceWarning: unclosed socket.socket about oci-python-sdk

[arthall]

Thank you, @tedpearson, for raising this issue.

Concerning the second warning message about collections, that is due to the version of Requests that we vendor. Requests has addressed it with version 2.19.0 and we are currently preparing a release with version 2.21.0 of Requests.

[tedpearson]

While I'm here I'll just pile this other warning into a comment...

/Users/ted/.local/share/virtualenvs/<snip>/lib/python3.7/site-packages/oci/_vendor/requests/models.py:181: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  if isinstance(hook, collections.Callable):

[arthall]

@tedpearson I believe I'm missing something here. Do you have a short sample program which produces the warning, "ResourceWarning: unclosed <socket.socket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('10.15.15.88', 61087), raddr=('129.146.14.197', 443)>"? I have tried to reproduce the warning in Python 3.5.1 and Python 3.7.2 with the currently vendored packages and the updated packages.

The base_client should be holding open sockets because it uses connection pools, but everything should be cleaned up when a client is no longer needed.

[tedpearson]

Hey Art, previously it was reproducible every time I ran some simple code, and now I can't reproduce at all either. I'm not sure what changed. I guess you can close this, and if it reoccurs I will remember to make a test case for you.

[arthall]

Thanks @tedpearson. I'm closing the issue for now.