Comments (4)
The problem with melted filenames described on https://java.net/projects/opengrok/lists/dev/archive/2013-03/message/33 probably went away to some degree (or was hidden) with e7cd132.
from opengrok.
Also, I discovered that findOriginalName() does not quite work correctly. It was comparing full revision string with short string which makes it fail for some of the changesets. This will be fixed too with this change.
from opengrok.
Facts:
- if user clicks on revision link in History view in the UI
hg cat -r REV FILE
is invoked and its output is displayed in HTML format. similarly when comparing 2 revisions, 2 such commands are invoked and their oututs compared and formatted. hg cat -r REV FILE
does not work for renamed files, for this to work theFILE
needs to be the original file name in revision REVhg log -f FILE
follows the renames of given file through renames (f
means follow), this allows to find the original name of the file so that it can be passed to thehg cat
command above- reindex of the whole repository basically performs
hg log
on the top-level directory of the repo and converts the output into list of HistoryEntry objects (one object maps to one changeset), together with files changes in given revision. File based cache then inverts this list and constructs a Map which maps file name into list of revisions which changed that file. This does not work for renamed files because the current name only maps to revisions in which it was changed under current name, not to revisions in which it was changed under the old name(s). Although JDBC cache does not perform this inversion (it is performed when querying by the DB) it has similar problem.
The overall approach to this fix:
- assemble a list of files which were changed (once or more, does not matter) during reindex
- store history cache entries for never-renamed files as is done currently. Once this is over get the full history for renamed files using getHistory() (which is able to find the complete history of the file because it runs
hg log -f FILE
) and generate the history entries for these files separately.
from opengrok.
For reference, this all started with #388.
from opengrok.
Related Issues (20)
- Dockerfile requests a vulnerable version of Apache Tomcat HOT 1
- Support GitHub repos that only allow checkout through web URLs
- History based reindex is on, however history is off. History has to be enabled for history based reindex HOT 1
- `opengrok-reindex-project` Triggers API-Ratelimit that doesn't reset
- Perforce Error in Project /& Git Repo
- ctags check prevents indexing of read-only filesystem HOT 1
- Opengrok notices newer files but does not rebuild the xref .gz files
- Opengrok notices newer files but does not rebuild the xref .gz files
- OpenGrok webapp fails to start after adding a project
- Opengrok UI shows incorrect results
- Restarting web server requires re-index of all projects HOT 1
- Searching special character is not working HOT 1
- The Dockerfile uses Apache Tomcat version 10.1.25-jdk17.
- superfluous stack trace produced when priting CacheException when annotation cache is disabled for a repository
- check Dockerfile for vulnerability alerts periodically and automatically HOT 6
- implement strip_outgoing() for Mercurial HOT 2
- few Git repos are not getting indexed
- incremental indexing fails with "attempting to add file with date matching deleted document" due to Git being too smart HOT 3
- Add support for $ in fortran identifiers and clickable .i include files. HOT 6
- opengrok java.lang.OutOfMemoryError: Java heap space
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opengrok.