Odd behavior on merged Orbit members about orbit-browser-extension

[martyndavies]

Hey @mattstratton, good catch, we'll take a look at this.

[phacks]

Thanks for opening the issue @mattstratton!

I think the reason why it does not work is that a few pieces of code (including the link to the profile) do not account for merges (or manual slug updates for that matter):

orbit-browser-extension/src/github/orbit-action.js

Lines 319 to 328 in a8edf55

	/**
	* <a href="…">See X’s profile on Orbit</a>
	*/
	const detailsMenuLinkProfile = window.document.createElement("a");
	detailsMenuLinkProfile.setAttribute("aria-label", "See profile on Orbit");
	detailsMenuLinkProfile.setAttribute("role", "menuitem");
	detailsMenuLinkProfile.setAttribute(
	"href",
	`${ORBIT_API_ROOT_URL}/${normalizedWorkspace}/members/${gitHubUsername}`
	);

I think we have the member slug at that point (although we might need to pass it as an argument) and thus could use it in places where we use githubUsername.

[martyndavies]

Hey @mattstratton, thanks again for highlighting this. It's now been fixed and a new version of the extension has been deployed to Google. It's available now, and might automatically update if you restart your browser, but you can always force the update by heading to chrome://extensions/, then 'Details' on the Orbit extension, and hit 'Update'.