GithubHelp home page GithubHelp logo

Comments (5)

chrischenyc avatar chrischenyc commented on May 18, 2024

i reckon it's Line 160 in PopupDialog.swift causing the issue
view = PopupDialogContainerView(frame: UIScreen.main.bounds)

from popupdialog.

mwfire avatar mwfire commented on May 18, 2024

Thanks for reporting this. I will look into this asap!

from popupdialog.

chrischenyc avatar chrischenyc commented on May 18, 2024

@mwfire any luck reproducing the issue? cheers!

from popupdialog.

chrischenyc avatar chrischenyc commented on May 18, 2024

by looking into the code, I reckon it's the auto-layout constraints that cause the issue.

I did followings:

  1. download the project
  2. run the example on iPhone 4S

I got this screenshot

simulator screen shot 12 dec 2016 6 13 03 pm

from popupdialog.

mwfire avatar mwfire commented on May 18, 2024

Hi @chenyuan!

I had a look at the code, ran examples on several devices and could not find any auto layout related issues. Although not a nice example for the iPhone 4S screen, having an image, title, text and three buttons just exceeds the screen height. I am not applying any extra scrolling logic to keep it simple.

The solution would be to either reduce your image heights for the smaller iPhones or use custom view controllers.

from popupdialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.