Comments (5)
I just don't like the wp coding standard about using underscores for naming functions and stuff. I prefer camelcase. But i think we should follow the codex right?
And besides, you are the girl in charge here :)
So yes, no problem.
from cmb2-grid.
I just don't like the wp coding standard about using underscores for naming functions and stuff. I prefer camelcase.
I get that. In a similar vain, I'm not a fan of yoda conditions.
I know people can feel quite strong about their preferred coding standards, which is why I asked the question ;-)
So what about using WPCS, but excluding the function naming rules ?
And besides, you are the girl in charge here :)
LOL, and there was me thinking it was your repo ;-)
from cmb2-grid.
LOL
I get that. In a similar vain, I'm not a fan of yoda conditions.
Don't like yoda conditions too. And to put curly braces on different lines neither.
So what about using WPCS, but excluding the function naming rules ?
Cool is it possible to do that? I prefer.
I'm realizing i can learn with you and I feel so happy you thought this project is worth spending time. I have to admit I was thinking about putting it aside. So yes it's your repository too :)
from cmb2-grid.
Cool is it possible to do that? I prefer.
Yup, no problem, I'll just need to figure out which rules to exclude. I'll get this sorted once the three PRs I opened earlier are merged to avoid everything conflicting with different spacing and such.
I'm realizing i can learn with you and I feel so happy you thought this project is worth spending time. I have to admit I was thinking about putting it aside. So yes it's your repository too :)
Thank you
I generally will always try to give back to projects I use, so you're very welcome.
from cmb2-grid.
PR #16 addresses this and selectively excludes a few rules. Have a look through if there are other rules you'd want to exclude as well or if you're ok with what I've done now.
from cmb2-grid.
Related Issues (20)
- Composer autoloading issue since recent update HOT 19
- CSS conflicting with colorpicker component HOT 2
- Box level `show_names` not respected
- Group Field Grid Issue HOT 2
- Some inputs are pre-filled in post-new.php HOT 1
- How to include it inside another plugin? HOT 9
- How to assign columns to repeatable groups HOT 1
- composer installer support HOT 2
- Update composer-installers HOT 1
- The plugin as standalone HOT 4
- Inherit composer.json from CMB2 + packagist HOT 3
- Group field grids causes errors if not before_row and after_row are set
- Groups in a row HOT 1
- Empty field with settings page HOT 8
- This just wont load. HOT 3
- How use it inside CMB2-tabs HOT 1
- CMB2-grid group classes not working HOT 3
- grid row missing default formatting
- Feature Request: Implementing CMB2-grid in a theme
- Support for php 8.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmb2-grid.