"TypeError: this.recipe is undefined" crash when saving recipe about cockpit-composer

[martinpitt]

I confirmed this both on the standalone server (http://localhost:3000) and in cockpit mode (http://localhost:9090/welder).

[martinpitt]

With npm run build:debug I get a stacktrace:

handleSaveRecipe http://localhost:9090/cockpit/@localhost/welder/dist/main.js:53248:11
	EditRecipePage/_this.handleSave http://localhost:9090/cockpit/@localhost/welder/dist/main.js:66151:32
	<anonym> self-hosted:943:17
	onClick http://localhost:9090/cockpit/@localhost/welder/dist/main.js:66583:32
	onClick self-hosted:987:17
	g http://localhost:9090/cockpit/@localhost/welder/dist/webcomponents-lite.js:72:107
	dispatchEvent http://localhost:9090/cockpit/@localhost/welder/dist/webcomponents-lite.js:143:92
	ReactErrorUtils.invokeGuardedCallback http://localhost:9090/cockpit/@localhost/welder/dist/main.js:27727:9
	executeDispatch http://localhost:9090/cockpit/@localhost/welder/dist/main.js:27513:7
	executeDispatchesInOrder http://localhost:9090/cockpit/@localhost/welder/dist/main.js:27536:7
	executeDispatchesAndRelease http://localhost:9090/cockpit/@localhost/welder/dist/main.js:26936:7
	executeDispatchesAndReleaseTopLevel http://localhost:9090/cockpit/@localhost/welder/dist/main.js:26947:12
	forEach self-hosted:267:13
	forEachAccumulated http://localhost:9090/cockpit/@localhost/welder/dist/main.js:27824:7
	processEventQueue http://localhost:9090/cockpit/@localhost/welder/dist/main.js:27147:9
	runEventQueueInBatch http://localhost:9090/cockpit/@localhost/welder/dist/main.js:34673:5
	handleTopLevel http://localhost:9090/cockpit/@localhost/welder/dist/main.js:34683:7
	handleTopLevelImpl http://localhost:9090/cockpit/@localhost/welder/dist/main.js:39659:7
	perform http://localhost:9090/cockpit/@localhost/welder/dist/main.js:30238:15
	batchedUpdates http://localhost:9090/cockpit/@localhost/welder/dist/main.js:39577:16
	batchedUpdates http://localhost:9090/cockpit/@localhost/welder/dist/main.js:28891:12
	dispatchEvent http://localhost:9090/cockpit/@localhost/welder/dist/main.js:39734:9
	dispatchEvent self-hosted:987:17
	g http://localhost:9090/cockpit/@localhost/welder/dist/webcomponents-lite.js:72:107

[henrywang]

@jgiardino @jkozol could you please take a look at this issue? This issue causes one of e2e test case fail sometimes, not always. Thanks!

[jgiardino]

Without stepping through the code, this appears to be an issue with saving a recipe that has no contents. This issue might be resolved as part of the work that Jacob is doing with Save. Some of the UI updates for Save would disable the Save button if there are no changes to save.

I'm only able to reproduce this for the followings steps:

1. Create a new recipe
2. Click Save

However I don't get the same issue when I complete the following steps:

1. Create a new recipe
2. add a package
3. remove the package
4. Click Save

[martinpitt]

This is now fixed with @jkozol's saving rework, the Save button is disabled while the recipe is empty.