GithubHelp home page GithubHelp logo

Unexpected aspect ratio format about embed HOT 3 OPEN

tremby avatar tremby commented on June 9, 2024
Unexpected aspect ratio format

from embed.

Comments (3)

oscarotero avatar oscarotero commented on June 9, 2024 1

Fair enough. I have edited the README.md file to improve the explanation for this property.

from embed.

oscarotero avatar oscarotero commented on June 9, 2024

The ratio property was added before CSS supported aspect-ratio property. The purpose was to replicate it using the padding hack (more info here: https://nikitahl.com/css-aspect-ratio)

Now that CSS supports aspect-ratio, probably this property doesn't make sense because you can do simply:

$css_aspect_ratio = "$code->width / $code->height";

from embed.

tremby avatar tremby commented on June 9, 2024

Regardless of its original purpose, and of the capabilities of CSS, and of whether you agree that most developers would be surprised to receive the current value, the logic used and the value returned do not agree with what is promised in the documentation.

from embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.