Comments (3)
Fair enough. I have edited the README.md file to improve the explanation for this property.
from embed.
The ratio
property was added before CSS supported aspect-ratio
property. The purpose was to replicate it using the padding hack (more info here: https://nikitahl.com/css-aspect-ratio)
Now that CSS supports aspect-ratio
, probably this property doesn't make sense because you can do simply:
$css_aspect_ratio = "$code->width / $code->height";
from embed.
Regardless of its original purpose, and of the capabilities of CSS, and of whether you agree that most developers would be surprised to receive the current value, the logic used and the value returned do not agree with what is promised in the documentation.
from embed.
Related Issues (20)
- [Question] Vimeo with "Hide from Vimeo" setting but embeds allowed on specific domains HOT 4
- request's locale change support HOT 2
- psr/http-message V2 support?
- Maximum redirects followed instagram HOT 3
- New release? HOT 1
- Twitter embed->get returns null on production HOT 5
- Twitter extractor will retrieve "/home" instead of a tweet URL HOT 2
- Reddit data is very lacking
- The demo site is offline HOT 3
- It is not work for same domain
- wrong extracted data when fetching image link behind redirect
- Memory leak HOT 8
- Setting user agent for request does not seem to work HOT 2
- Add option to fetch OEmbed only HOT 2
- CURL error when embedding Twitter HOT 2
- Problem in URLs of MVCs without file extentions in some server...
- Large quantities of embed-cookies-{uid} are being created, but not deleted? HOT 2
- Use maxresdefault instead of hqdefault for YouTube embeds HOT 2
- Twitter.com to X.com migration giving errors HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from embed.