GithubHelp home page GithubHelp logo

Comments (2)

bjhargrave avatar bjhargrave commented on May 20, 2024

Comment author: Dmytro Pishchukhin <[email protected]>

Errata:
124.5.6 Boolean and boolean types are missed in property type syntax.
124.8.3.28 P_BOOLEAN type is missed in SCALAR list
124.9.4.6 NAME_ITEM type should be SimpleType.STRING
124.9.5.16 SERVICE_EVENT_TYPE misses BUNDLE_IDENTIFIER type. BUNDLE_IDENTIFIER_ITEM is a part of SERVICE_EVENT_TYPE
124.9.5.25 IllegalArgumentException never throws in listServices() method

Unclear points:

  • BundleEvents and ServiceEvents handling (124.9.2.2, 124.9.5.16). 124.2.3 can contain information how to provide JMX notification (MBean should implement javax.management.NotificationBroadcaster)
  • There is no infomration how to register MBean for every instance of Compendium Service (124.3.2, 124.3.4). What ObjectName key property should be added to Compendium Service OBJECTNAME (",service.id=?")

Some small API improvements:
124.9.3.22, 124.9.3.27 - can throw IllegalArgumentException if the bundle indicated does not exist
124.9.3.21, 124.9.3.28, 124.9.3.41 - can throw IllegalArgumentException if locations/bundleIdentifiers and urls/newlevels arrays are null or have different lenght
124.13.1.22 - can throw IllegalArgumentException if the groupname is not a Group
124.13.1.32, 124.13.1.38, 124.13.1.40 - can throw IllegalArgumentException if the filter is invalid
124.13.1.46 - can throw IllegalArgumentException if the groupname is not a Group
124.13.1.50 - can throw IllegalArgumentException if the username is not a User

from design.

bjhargrave avatar bjhargrave commented on May 20, 2024

Comment author: @bosschaert

Needs to be taken into account in the RFC 169 work.

from design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.