GithubHelp home page GithubHelp logo

Tooltip no longer showing up about raidbrowser HOT 7 CLOSED

ostoic avatar ostoic commented on June 10, 2024 3
Tooltip no longer showing up

from raidbrowser.

Comments (7)

adechan avatar adechan commented on June 10, 2024 2

Works great! Nice job @MassCraxx <3

from raidbrowser.

Ostoic avatar Ostoic commented on June 10, 2024 1

I'll look into this tonight when I get off work. Thanks for making an issue!

from raidbrowser.

Ostoic avatar Ostoic commented on June 10, 2024 1

Actually instead of all that nonsense (lol), I think Warmane just slightly modified the behavior of GetSavedInstanceInfo. Instead of returning (what I believe was) 0 for the number of seconds remaining until one of your saved instances resets, they return nil in the event that an instance is not saved. Perhaps @MassCraxx might be able to provide some insight?

from raidbrowser.

MassCraxx avatar MassCraxx commented on June 10, 2024

I might have found a solution for this.
Maybe test out https://github.com/MassCraxx/RaidBrowser/tree/dev and let me know if this works for you.

from raidbrowser.

kylep1998 avatar kylep1998 commented on June 10, 2024

i copied your core and gui files and it works now @MassCraxx

from raidbrowser.

SimonVerboven avatar SimonVerboven commented on June 10, 2024

Can confirm it's working here as well. Downloaded the core & gui files and replaced my local ones and things are working fine again. Did something change on Warmane side? Bit odd it stopped working out of the blue.

from raidbrowser.

Ostoic avatar Ostoic commented on June 10, 2024

Can confirm it's working here as well. Downloaded the core & gui files and replaced my local ones and things are working fine again. Did something change on Warmane side? Bit odd it stopped working out of the blue.

Honestly, I'm not exactly sure what happened. I haven't been playing WoW recently, and the only thing I've heard from friends that do still play is that they restricted the global channel to ASCII text only.

I saw that @MassCraxx fixed a bug where the wrong variable name was returned for the minutes text in the time formatting function in gui.lua. Otherwise, they just moved the OnClick and OnEnter/OnLeave listeners into a more sane location. Perhaps because of this, there was a global variable name conflict that was causing the function to return a null value instead of the number of minutes since the last message was sent.

As for a change by Warmane, the only thing I could think of that would allow Warmane to modify Lua on the client-side is a new anticheat scan. One of the checks they used to do is to inject Lua into the client to test for global variables or chat messages that would indicate PQR or EWT usage. Perhaps they are polluting the global namespace? Occam's razor suggests this is probably something else though.

from raidbrowser.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.