GithubHelp home page GithubHelp logo

Comments (2)

ouhammmourachid avatar ouhammmourachid commented on June 1, 2024

Dear @HASPIMA ,

Thank you for reaching out and providing valuable feedback on the library. I truly appreciate your detailed explanation of the issue you encountered and the proposed solutions to address it.

After carefully considering your suggestions, I agree that modifying the regular expression to allow dots (.) and dashes (-) would be a beneficial enhancement to the library. This change would enable users to maintain the desired structure of their node identifiers without losing important information during the conversion process.

Moreover, I believe that this adjustment will not cause any compatibility issues as it expands the range of characters allowed in node identifiers while preserving the existing functionality for users who prefer snake case format.

from mermaid-py.

HASPIMA avatar HASPIMA commented on June 1, 2024

Hey @ouhammmourachid, thank you for your insightful feedback. After evaluating what we said, I agree #99 would be a better solution candidate for this issue, in the meantime I'll be closing #100 referencing this comment.

Thanks so much for your quick response, I'll keep on finishing #99 just so we can have this issue fixed. Ohh, more thing, can you add this repository to the PyPi project? It took me longer than it should have, to find this repo heheh, that'll be much appreciated. Have a good one!

from mermaid-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.